From owner-freebsd-ipfw@FreeBSD.ORG  Thu Apr 17 17:48:28 2008
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: ipfw@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A9B701065671
	for <ipfw@freebsd.org>; Thu, 17 Apr 2008 17:48:28 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outQ.internet-mail-service.net (outq.internet-mail-service.net
	[216.240.47.240])
	by mx1.freebsd.org (Postfix) with ESMTP id 997018FC23
	for <ipfw@freebsd.org>; Thu, 17 Apr 2008 17:48:28 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160)
	by out.internet-mail-service.net (qpsmtpd/0.40) with ESMTP;
	Thu, 17 Apr 2008 21:52:31 -0700
Received: from julian-mac.elischer.org (localhost [127.0.0.1])
	by idiom.com (Postfix) with ESMTP id D9F982D6011;
	Thu, 17 Apr 2008 10:48:27 -0700 (PDT)
Message-ID: <48078D71.403@elischer.org>
Date: Thu, 17 Apr 2008 10:48:33 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213)
MIME-Version: 1.0
To: "Andrey V. Elsukov" <bu7cher@yandex.ru>
References: <4806BA59.4030106@elischer.org> <4806E468.5030906@yandex.ru>
In-Reply-To: <4806E468.5030906@yandex.ru>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Cc: FreeBSD Net <freebsd-net@freebsd.org>, ipfw@freebsd.org,
	Luigi Rizzo <rizzo@icir.org>
Subject: Re: addition to ipfw table..
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Apr 2008 17:48:28 -0000

Andrey V. Elsukov wrote:
> Julian Elischer wrote:
>> I do know it won't handle non contiguous masks well but as the
>> ipfw ABI code only accepts a network mask length instead of a
>> mask, there's not much that can be done.
>> I may suggest a later fix for that but it will break the ABI.
>>
>> comments?
> 
> What you think about my patch?
> 

I like it.. :-)
I didn't know about contigmask()