Date: Fri, 25 Jun 2004 12:38:27 +0000 From: Alexander Kabaev <kan@FreeBSD.org> To: Dag-Erling Sm?rgrav <des@des.no> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_radius pam_radius.c Message-ID: <20040625123827.GA55913@freefall.freebsd.org> In-Reply-To: <xzp1xk325pg.fsf@dwp.des.no> References: <200406250154.i5P1sQcp072094@repoman.freebsd.org> <xzp659g0ywd.fsf@dwp.des.no> <20040625120329.GB37003@ip.net.ua> <xzp1xk325pg.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 25, 2004 at 02:16:27PM +0200, Dag-Erling Sm?rgrav wrote: > Ruslan Ermilov <ru@FreeBSD.org> writes: > > On Fri, Jun 25, 2004 at 11:28:50AM +0200, Dag-Erling Sm?rgrav wrote: > > > Alexander Kabaev <kan@FreeBSD.org> writes: > > > > Log: > > > > Remove the use of cast as lvalue. > > > This trades one style bug for another (missing space before *), breaks > > > the build on 64-bit platforms, and violates maintainership. > > Ah, so this commit is responsible for a cross-build breakage... > > No, this one currently only breaks Alpha because we apparently don't > enforce alignment requirements on other platforms. > It definitely worked for amd64 world, which I guess does not have such strict alignment requirements. I backed out the change and will let maintainer to deal with it to his heart desire. Apologies for DES for intruding on his turf. I will downgrade WARNS level for this module at the time of GCC 3.4 import if the warning will still be there by then. -- Alexander Kabaev
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040625123827.GA55913>