From owner-freebsd-bugs Tue Jan 14 20:40:04 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA04020 for bugs-outgoing; Tue, 14 Jan 1997 20:40:04 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.4/8.8.4) id UAA04014; Tue, 14 Jan 1997 20:40:02 -0800 (PST) Date: Tue, 14 Jan 1997 20:40:02 -0800 (PST) Message-Id: <199701150440.UAA04014@freefall.freebsd.org> To: freebsd-bugs Cc: From: mark thompson Subject: Re: bin/2493: make $DESTDIR work Reply-To: mark thompson Sender: owner-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk The following reply was made to PR bin/2493; it has been noted by GNATS. From: mark thompson To: joerg_wunsch@uriah.heep.sax.de Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: bin/2493: make $DESTDIR work Date: Tue, 14 Jan 1997 20:34:37 -0800 (PST) Date: Wed, 15 Jan 1997 01:05:30 +0100 From: j@uriah.heep.sax.de (J Wunsch) References: <199701141416.GAA21689@squirrel.tgsoft.com> Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) As mark thompson wrote: > Enclosed is a set of diffs (mostly to makefiles) that make them respect > $DESTDIR. > -INCDIRS= -I/usr/include/rpcsvc > +INCDIRS= -I${DESTDIR}/usr/include/rpcsvc (etc.) I think ${DESTDIR} is only guaranteed to what its name says: a destination directory. This will only work to _install_ an already compiled tree (and this feature is heavily relied on during the release build process). I'm not sure what other people think, but i'm of the opinion that your patches try to extend the idea of ${DESTDIR}. I believe that whether or not ${DESTDIR} was 'guaranteed' to do what i want (allow you to do a make world without overwritting your running system), 90% of the Makefiles are coded so you can do just that. The changes that i submitted take you to between 95-99% of the way there and *should not* break anything. If these changes are too high a risk to put into the sources, fine with me. I did them for my own purposes, and am happy just to offer the results back as a contribution. -mark