Date: Mon, 6 Jan 2014 12:15:01 -0800 From: Jason Helfman <jgh@FreeBSD.org> To: Mathieu Arnold <mat@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Jason Helfman <jgh@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r338802 - in head/textproc: docbook-241 docbook-300 docbook-310 docbook-400 docbook-410 docbook-440 docbook-450 docbook-500 docbook-xml-450 Message-ID: <CAMuy=%2Bg7pjyET5HSZXo9NUzxPYYbw9KL6KxCWCf81cf1%2Bqkn_w@mail.gmail.com> In-Reply-To: <646831BE6E0393D4F36AB5CC@ogg.in.absolight.net> References: <201401051721.s05HLNPn088802@svn.freebsd.org> <201401051728.s05HSamN089750@svn.freebsd.org> <646831BE6E0393D4F36AB5CC@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 6, 2014 at 6:22 AM, Mathieu Arnold <mat@freebsd.org> wrote:
> +--On 5 janvier 2014 17:21:23 +0000 Jason Helfman <jgh@FreeBSD.org> wrote:
> | Log:
> | - fix pkgname collisions
> | -LATEST_LINK= docbook-241
> | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
> | -LATEST_LINK= docbook-300
> | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
> | -LATEST_LINK= docbook-310
> | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
> | -LATEST_LINK= docbook-400
> | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
> | -LATEST_LINK= docbook-410
> | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
> | -LATEST_LINK= ${PORTNAME}-440
> | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
> | -LATEST_LINK= ${PORTNAME}-450
> | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
> | -LATEST_LINK= ${PORTNAME}-500
> | +PKGNAMESUFFIX= ${PKGORIGIN:T:S/docbook-//}
>
> Why the overly complicated computation where you could just have put the
> number that was in the LATEST_LINK right away ?
>
Those ports version will never change, so it's not likely that anyone will
> ever have to update the PKGNAMESUFFIX.
>
To me, this seems to be a style issue. If there is a problem with this,
then please send a patch for approval to gabor@
> | -LATEST_LINK= ${PORTNAME}-450
> | +PKGNAMESUFFIX= ${PORTVERSION:S/.//}
> | -LATEST_LINK= ${PORTNAME}-440
> | +PKGNAMESUFFIX= ${PORTVERSION:S/.//}
>
> And there, why the change of heart ? Now, we have a package named
> docbook440 and one named docbook-xml44, which is rather not consistent at
> all.
>
>
I based these off of the PORTVERSION, rather than the ORIGIN, and didn't
see an issue. I also wasn't comparing it to
docbook pkgnames, but was comparing it with docbook-xml pkgnames. Beyond
this, the maintainer approved the patches
that has both docbook and docbook-xml ports.
-jgh
Regards,
>
> --
> Mathieu Arnold
>
>
--
Jason Helfman | FreeBSD Committer
jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMuy=%2Bg7pjyET5HSZXo9NUzxPYYbw9KL6KxCWCf81cf1%2Bqkn_w>