From owner-svn-src-all@freebsd.org  Sat Mar  5 06:13:53 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF88DA09914;
 Sat,  5 Mar 2016 06:13:53 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id AA19919A;
 Sat,  5 Mar 2016 06:13:53 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [IPv6:::1])
 by freefall.freebsd.org (Postfix) with ESMTP id A407E14B0;
 Sat,  5 Mar 2016 06:13:53 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [172.31.3.2])
 by mail.xzibition.com (Postfix) with ESMTP id 5E574164B4;
 Sat,  5 Mar 2016 06:13:53 +0000 (UTC)
X-Virus-Scanned: amavisd-new at mail.xzibition.com
Received: from mail.xzibition.com ([172.31.3.2])
 by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new,
 port 10026)
 with LMTP id I6XDTGgZHnss; Sat,  5 Mar 2016 06:13:50 +0000 (UTC)
Subject: Re: svn commit: r296406 - head/lib
DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 096E0164AA
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201603050539.u255dxQl080458@repo.freebsd.org>
From: Bryan Drewery <bdrewery@FreeBSD.org>
Organization: FreeBSD
Message-ID: <56DA791B.2030205@FreeBSD.org>
Date: Fri, 4 Mar 2016 22:13:47 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <201603050539.u255dxQl080458@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Mar 2016 06:13:53 -0000

On 3/4/16 9:39 PM, Bryan Drewery wrote:
> Author: bdrewery
> Date: Sat Mar  5 05:39:59 2016
> New Revision: 296406
> URL: https://svnweb.freebsd.org/changeset/base/296406
> 
> Log:
>   Revert r296395.
>   
>   This mistakenly removed the SUBDIR_PARALLEL but even worse is that the install
>   (and build) order is not correct due to the lack of SUBDIR_DEPEND on the
>   most critical libraries.  The only reason they build correctly now is because
>   buildworld's 'make libraries' orders them properly.

Bonus, the addition of SUBDIR_DEPEND in lib/Makefile in r267511
technically breaks non-parallel builds since it de-ordered everything
and has relied on the ordering in Makefile.inc1 even more.

I had tried to make bsd.subdir.mk create targets for each subdir even
without -j before mostly as an attempt to simplify it some.  If I can
pull that off though then we can use the SUBDIR_DEPEND for non-parallel
builds as well.

-- 
Regards,
Bryan Drewery