From owner-freebsd-perl@FreeBSD.ORG Tue Jul 8 01:41:31 2014 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 13C4A409; Tue, 8 Jul 2014 01:41:31 +0000 (UTC) Received: from exodus.zi0r.com (exodus.zi0r.com [71.179.14.195]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "exodus.zi0r.com", Issuer "Gandi Standard SSL CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F059298D; Tue, 8 Jul 2014 01:41:30 +0000 (UTC) Received: from exodus.zi0r.com (localhost [127.0.0.1]) by exodus.zi0r.com (Postfix) with ESMTP id A9F113A09A; Mon, 7 Jul 2014 21:41:27 -0400 (EDT) X-Virus-Scanned: amavisd-new at zi0r.com Received: from exodus.zi0r.com ([127.0.0.1]) by exodus.zi0r.com (exodus.zi0r.com [127.0.0.1]) (amavisd-new, port 10026) with LMTP id hhw1GeRAEdNK; Mon, 7 Jul 2014 21:41:27 -0400 (EDT) Received: from exodus.zi0r.com (syn.zi0r.com [71.179.14.194]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by exodus.zi0r.com (Postfix) with ESMTPSA id E4CD73A099; Mon, 7 Jul 2014 21:41:26 -0400 (EDT) Date: Mon, 7 Jul 2014 21:41:25 -0400 From: Ryan Steinmetz To: Baptiste Daroussin Subject: Re: p5-Git-Repository Message-ID: <20140708014125.GA97285@exodus.zi0r.com> References: <53BA9AD8.7030906@myarcher.net> <20140707134409.GA12289@exodus.zi0r.com> <20140707161318.GB74596@exodus.zi0r.com> <20140707161913.GB97203@ivaldir.etoilebsd.net> <20140707162734.GC74596@exodus.zi0r.com> <20140707185025.GC97203@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20140707185025.GC97203@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Mathieu Arnold , Barrie Archer , perl@freebsd.org, portmgr@freebsd.org X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jul 2014 01:41:31 -0000 On (07/07/14 20:50), Baptiste Daroussin wrote: >> .if (${OSVERSION} >= 902510 && ${OSVERSION} < 1000000) || ${OSVERSION} >= 1000704 >> ${ECHO} "You are using an unsupported release. The ports tree may not >> function correctly. Please update to a supported release for the best >> experience. See http://.....freebsd.org/... for a list of supported >> releases. >> .endif >> >> Obviously the versions are not correct, but, again, the goal is to give >> people something to work with. Just like what we did with the PKGNG >> warnings. >> >> -r >> >that won t work because you will have a syntax error before being able to print >that > >Bapt My goal was to get the idea across. As for an actual implementation: 1. We could rename bsd.port.mk to something else and add the version checks in the 'new' bsd.port.mk, followed by a .include for the real bsd.port.mk. 2. Wrap the actual content of bsd.port.mk in the else block of an if block. In this case, the if block would be our version checks. I'm sure there are also other possibilities, these were just those that came to mind. -r -- Ryan Steinmetz PGP: 9079 51A3 34EF 0CD4 F228 EDC6 1EF8 BA6B D028 46D7