From owner-freebsd-net Thu Apr 27 11:15:35 2000 Delivered-To: freebsd-net@freebsd.org Received: from luxren2.boostworks.com (luxren2.boostworks.com [194.167.81.214]) by hub.freebsd.org (Postfix) with ESMTP id 75B6D37B813 for ; Thu, 27 Apr 2000 11:15:31 -0700 (PDT) (envelope-from root@boostworks.com) Received: from boostworks.com (root@oldrn.luxdev.boostworks.com [192.168.1.99]) by luxren2.boostworks.com (8.9.1/8.9.1) with ESMTP id UAA49981; Thu, 27 Apr 2000 20:15:05 +0200 (CEST) Message-Id: <200004271815.UAA49981@luxren2.boostworks.com> Date: Thu, 27 Apr 2000 20:15:14 +0200 (CEST) From: Remy Nonnenmacher Reply-To: remy@boostworks.com Subject: Re: Proposal for ethernet, bridging, netgraph To: archie@whistle.com Cc: freebsd-net@FreeBSD.ORG In-Reply-To: <200004271740.KAA66052@bubba.whistle.com> MIME-Version: 1.0 Content-Type: TEXT/plain; CHARSET=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On 27 Apr, Archie Cobbs wrote: > CC: to -committers > > I'm planning to check in this patch soon: > > ftp://ftp.whistle.com/pub/archie/misc/net.cleanup.patch.3 > > The goal of the patch is simply to move the BPF and BRIDGE taps on > Ethernet frame input from the individual drivers up into ether_input(), > while attempting to preserve any existing "avoid unnecessarily > reading packets" optimizations (specifically in the if_ed.c and > if_ie.c drivers). > > The result: > > 1140 lines removed > 187 lines added > > This patch has been reviewed by freebsd-net already, but I'm trying > to give a lot of warning because.. > > o I don't have all 47 types of Ethernet cards to test. In fact > my -current machine only has one so I can't even test BRIDGE'ing. > At least BPF still works :-) > > o It's not completely clear which drivers are shared with other > versions of 'BSD -- if I've missed any, they will need some > #ifdef __FreeBSD__ modifications. > > Thanks! > -Archie > > P.S.: there are lots of other "cleanups" that could be done; > please discuss these on freebsd-net (i.e., remove -committers). > Archie, in case you've not got my previous message: this patch _breaks_ the bridging: someone (hi Luigi ?) will have really hard work getting it back on. RN. IeM To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message