Date: Fri, 12 May 2006 06:53:27 -0700 From: Luigi Rizzo <rizzo@icir.org> To: Patrick Tracanelli <eksffa@freebsdbrasil.com.br> Cc: Vadim Goncharov <vadim_nuclight@mail.ru>, freebsd-net@freebsd.org, freebsd-ipfw@freebsd.org Subject: Re: [patch] ipfw packet tagging Message-ID: <20060512065327.B16302@xorpc.icir.org> In-Reply-To: <44648E66.6010800@freebsdbrasil.com.br>; from eksffa@freebsdbrasil.com.br on Fri, May 12, 2006 at 10:32:22AM -0300 References: <ops9fwnzbw17d6mn@nuclight.avtf.net> <44648E66.6010800@freebsdbrasil.com.br>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 12, 2006 at 10:32:22AM -0300, Patrick Tracanelli wrote: > Vadim Goncharov wrote: > > Hi, All! > > > > I've tried Andrey Elsukov's ipfw "tag/tagged" patches from: > > http://butcher.heavennet.ru/patches/kernel/ipfw_tags/ > > > > Tested on 5.5-PRERELEASE production server with moderate > > load - rock stable [I've also looked through the code - patch > > is small, so it simply can't be any bugs there ;)]. > > > > Personally I very like the idea from original Andrey's letter > > I have tested on 6.1 and works fine too. > > Hope it gets commited. Very useful for altq/dummynet flexibility too. i would, however, like to have a bit more documentation in the patch, in particular: - a manpage patch describing how to use the thing, and also the behaviour in in odd situations (e.g. what happens when we try to tag a packet multiple times ? does the tag survive between the 'input' and 'output' path of ipfw for routed packets, etc ?). I can look this up in the code, but the average user cannot, and the patch does not contain a single line of comment, plus we generally want to have some textual description of the behaviour (so we can RTFM), not just an implementation without comments. - more comments in the code, per the above. cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060512065327.B16302>