Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 May 2015 13:02:54 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Gleb Smirnoff <glebius@freebsd.org>
Cc:        Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r283538 - head/sys/net80211
Message-ID:  <1496924.Xgdmz2A7b4@ralph.baldwin.cx>
In-Reply-To: <20150525193833.GW73119@FreeBSD.org>
References:  <201505251918.t4PJIGnk004558@svn.freebsd.org> <20150525193833.GW73119@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, May 25, 2015 10:38:33 PM Gleb Smirnoff wrote:
> On Mon, May 25, 2015 at 07:18:16PM +0000, Adrian Chadd wrote:
> A>   * kill M_WAITOK - some platforms just don't want you to use it
> 
> Actually all functions called in device attach context or in
> syscall context should use M_WAITOK. This makes API more robust and
> simplifies code a lot.
> 
> Can we achieve portability without losing this nice feature of
> FreeBSD?

I agree with this general policy.   There are several places that currently
use M_NOWAIT (e.g. new-bus) that could safely use M_WAITOK instead in many
cases (if not always).

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1496924.Xgdmz2A7b4>