From owner-cvs-all@FreeBSD.ORG Thu Jun 1 15:04:33 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9F3A16ADB3; Thu, 1 Jun 2006 15:04:33 +0000 (UTC) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9480743D45; Thu, 1 Jun 2006 15:04:33 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k51F37Mq028711; Thu, 1 Jun 2006 15:03:07 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k51F36hW028687; Thu, 1 Jun 2006 15:03:06 GMT (envelope-from maxim) Message-Id: <200606011503.k51F36hW028687@repoman.freebsd.org> From: Maxim Konovalov Date: Thu, 1 Jun 2006 15:03:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.sbin/cron/cron do_command.c popen.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2006 15:04:50 -0000 maxim 2006-06-01 15:03:06 UTC FreeBSD src repository Modified files: usr.sbin/cron/cron do_command.c popen.c Log: o Better be safe than sorry: check return code from setuid(2), setgid(2), setlogin(2) and initgroups(3). In theory they could fail for root with some third party mac(4) policies. Submitted by: Kostik Belousov MFC after: 1 month Revision Changes Path 1.24 +21 -4 src/usr.sbin/cron/cron/do_command.c 1.13 +9 -4 src/usr.sbin/cron/cron/popen.c