From owner-freebsd-fs@FreeBSD.ORG Sun Sep 6 08:17:10 2009 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D3C091065676; Sun, 6 Sep 2009 08:17:10 +0000 (UTC) (envelope-from mel.flynn+fbsd.fs@mailing.thruhere.net) Received: from mailhub.rachie.is-a-geek.net (rachie.is-a-geek.net [66.230.99.27]) by mx1.freebsd.org (Postfix) with ESMTP id 7D6868FC14; Sun, 6 Sep 2009 08:17:10 +0000 (UTC) Received: from smoochies.rachie.is-a-geek.net (mailhub.lan.rachie.is-a-geek.net [192.168.2.11]) by mailhub.rachie.is-a-geek.net (Postfix) with ESMTP id A36907E818; Sun, 6 Sep 2009 00:17:20 -0800 (AKDT) From: Mel Flynn To: Pawel Jakub Dawidek Date: Sun, 6 Sep 2009 10:17:05 +0200 User-Agent: KMail/1.11.4 (FreeBSD/8.0-BETA3; KDE/4.2.4; i386; ; ) References: <200909030000.11961.mel.flynn+fbsd.fs@mailing.thruhere.net> <200909060236.11224.mel.flynn+fbsd.fs@mailing.thruhere.net> <20090906065217.GL1665@garage.freebsd.pl> In-Reply-To: <20090906065217.GL1665@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200909061017.05990.mel.flynn+fbsd.fs@mailing.thruhere.net> Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org Subject: Re: Patch to allow gmirror to set priority of a disk X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Sep 2009 08:17:10 -0000 On Sunday 06 September 2009 08:52:17 you wrote: > On Sun, Sep 06, 2009 at 02:36:10AM +0200, Mel Flynn wrote: > > Hi, > > > > new patch containing everything and points for elegance. Double checked > > for style, so I'm sure there's one or two left ;). > > Yeah:) I'll fixed what's left by myself and tested it. With few little > changes it works fine, good job. Below, for the record, you can find > what I changed. Patch committed. Thank you very much! And now you got me thinking about allowing and enforcing two usage patterns of the same command in the core geom, so that the enforcement can be stripped out of command implementations. But I'll leave that for a time when this is not the only consumer of that logic. This has nonetheless been a welcome learning experience. -- Mel