From owner-svn-src-user@FreeBSD.ORG  Wed Oct 31 20:51:42 2012
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 7668EA9B;
 Wed, 31 Oct 2012 20:51:42 +0000 (UTC)
 (envelope-from crees@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
 by mx1.freebsd.org (Postfix) with ESMTP id 5B4ED8FC08;
 Wed, 31 Oct 2012 20:51:42 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
 by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q9VKpg6v028334;
 Wed, 31 Oct 2012 20:51:42 GMT (envelope-from crees@svn.freebsd.org)
Received: (from crees@localhost)
 by svn.freebsd.org (8.14.4/8.14.4/Submit) id q9VKpgcl028332;
 Wed, 31 Oct 2012 20:51:42 GMT (envelope-from crees@svn.freebsd.org)
Message-Id: <201210312051.q9VKpgcl028332@svn.freebsd.org>
From: Chris Rees <crees@FreeBSD.org>
Date: Wed, 31 Oct 2012 20:51:42 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
Subject: svn commit: r242405 - user/crees/rclint
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2012 20:51:42 -0000

Author: crees (ports committer)
Date: Wed Oct 31 20:51:41 2012
New Revision: 242405
URL: http://svn.freebsd.org/changeset/base/242405

Log:
  Be more relaxed about quoting by being observant of POSIX, rather than our
  sh's behaviour
  
  Submitted by:	jilles

Modified:
  user/crees/rclint/rclint.py

Modified: user/crees/rclint/rclint.py
==============================================================================
--- user/crees/rclint/rclint.py	Wed Oct 31 19:17:55 2012	(r242404)
+++ user/crees/rclint/rclint.py	Wed Oct 31 20:51:41 2012	(r242405)
@@ -109,11 +109,10 @@ class Statement:
 
     def pointless_quoted(self):
         if self.quoted():
-            if self.type == 'shorthand':
-                return True
-            elif ' ' not in self.value and '\t' not in self.value:
-                return True
-        return False
+            for char in self.value:
+                if char in ' \t|&;<>()$`\\\"\'':
+                    return False
+        return True
 
 class Variable(Statement):
     def __init__(self, lines, number):