From owner-freebsd-standards@FreeBSD.ORG Thu Apr 23 23:00:15 2009 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC19D1065670 for ; Thu, 23 Apr 2009 23:00:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 38FC48FC25 for ; Thu, 23 Apr 2009 23:00:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n3NN02Li057958 for ; Thu, 23 Apr 2009 23:00:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n3NN02jb057957; Thu, 23 Apr 2009 23:00:02 GMT (envelope-from gnats) Date: Thu, 23 Apr 2009 23:00:02 GMT Message-Id: <200904232300.n3NN02jb057957@freefall.freebsd.org> To: freebsd-standards@FreeBSD.org From: Jilles Tjoelker Cc: Subject: Re: standards/116826: [patch] sh support for POSIX character classes X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jilles Tjoelker List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2009 23:00:15 -0000 The following reply was made to PR standards/116826; it has been noted by GNATS. From: Jilles Tjoelker To: bug-followup@FreeBSD.org, uberlord@gentoo.org Cc: Subject: Re: standards/116826: [patch] sh support for POSIX character classes Date: Fri, 24 Apr 2009 00:52:12 +0200 The patch seems to work in brief testing. The code seems to be taken from dash, and an attribution/copyright notice seems missing. I put an improved patch (also including a bug fix from dash) on http://www.stack.nl/~jilles/unix/sh-match-charclass.patch Recent versions of dash can use fnmatch(3) (and also glob(3)) instead of the internal implementations; this is however not used by default (I suppose it was added to make it possible to build smaller binaries; dash is also obfuscated in some places to decrease binary size). It requires converting the CTLESC etc quoting to backslash quoting. This could be nice in that our fnmatch supports multibyte characters; however it does not support the [:alpha:] classes either. -- Jilles Tjoelker