Date: Sun, 20 Jul 2003 12:22:30 +1000 From: Tim Robbins <tjr@FreeBSD.ORG> To: freebsd-fs@freebsd.org Subject: Re: NFS ftruncate patch for review Message-ID: <20030720022230.GA82881@dilbert.robbins.dropbear.id.au> In-Reply-To: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au> References: <20030718064120.GA72366@dilbert.robbins.dropbear.id.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 18, 2003 at 04:41:20PM +1000, Tim Robbins wrote: > Any comments on this patch? The referenced PR contains more comments and a > test program. It's not obvious from the diff, but the changes are to > nfs_setattr() in the va_size != VNOVAL && v_type == VREG case. It turns out that it's nfs_loadattrcache() that is changing n_size when called indirectly from nfs_meta_setsize() in the test case. (Re-)setting n_size before returning from nfs_setattr() is still correct, but the comment was wrong. Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030720022230.GA82881>