Date: Tue, 18 Jan 2011 21:58:07 +0100 From: Tijl Coosemans <tijl@coosemans.org> To: freebsd-current@freebsd.org Cc: Ulrich =?iso-8859-1?q?Sp=F6rlein?= <uqs@freebsd.org> Subject: Re: FYI: clang static analyzer page has moved to http://scan.freebsd.your.org/freebsd-head/ Message-ID: <201101182158.14438.tijl@coosemans.org> In-Reply-To: <20110105131439.GN23329@acme.spoerlein.net> References: <20110105131439.GN23329@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart9189369.4dPBRS3gXQ Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Wednesday 05 January 2011 14:14:39 Ulrich Sp=F6rlein wrote: > Now that I'm fairly confident that the stability issues with your.org's > VMs have been resolved, I'd like to point you to the new and improved, > semi-weekly analyzer runs at >=20 > http://scan.freebsd.your.org/freebsd-head/ I came across an interesting false positive here: http://scan.freebsd.your.org/freebsd-head/sbin.geom.class/2011-01-15-amd64/= report-1aAmgE.html#EndPath | assert((strcmp(type, "keyfile") =3D=3D 0 && ctxp !=3D NULL && | passbuf =3D=3D NULL && passbufsize =3D=3D 0) || | (strcmp(type, "passfile") =3D=3D 0 && ctxp =3D=3D NULL && | passbuf !=3D NULL && passbufsize > 0)); | assert(strcmp(type, "keyfile") =3D=3D 0 || passbuf[0] =3D=3D '\0'); |=20 | Within the expansion of the macro 'assert': | Array access (from variable 'passbuf') results in a null pointer | dereference. I think the problem here is that the analyser allows strcmp(type, "keyfile") to return zero in the first assertion and nonzero in the second. This cannot happen of course and the analyser should know that because strcmp has been declared __pure__ in string.h. A workaround in this case would be to merge the two assertions. --nextPart9189369.4dPBRS3gXQ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iF4EABEIAAYFAk01/uYACgkQfoCS2CCgtiuvnAD9HbPuaXnmh16KSckJRAeG+/C/ Mp8MwFGz1okKYlpEmGoA/2TJiTkssuurcap3/2fEra39L6IDMaYBL0xinJ+kmJSB =zv60 -----END PGP SIGNATURE----- --nextPart9189369.4dPBRS3gXQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101182158.14438.tijl>