Date: Thu, 25 Jun 2009 13:19:24 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Rafal Jaworowski <raj@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r194844 - in head/sys: conf dev/ata Message-ID: <4A434F2C.1020005@FreeBSD.org> In-Reply-To: <200906241538.n5OFcHwp018860@svn.freebsd.org> References: <200906241538.n5OFcHwp018860@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Rafal Jaworowski wrote: > Author: raj > Date: Wed Jun 24 15:38:17 2009 > New Revision: 194844 > URL: http://svn.freebsd.org/changeset/base/194844 > > Log: > Move non-PCI prototypes from ata-pci.h -> ata-all.h. > > This removes unnecessary PCI #includes dependency for systems with ATA > controllers living at non-PCI buses. > > Submitted by: Piotr Ziecik > Obtained from: Semihalf > > Modified: head/sys/conf/files > ============================================================================== > --- head/sys/conf/files Wed Jun 24 15:33:33 2009 (r194843) > +++ head/sys/conf/files Wed Jun 24 15:38:17 2009 (r194844) > @@ -491,12 +491,12 @@ dev/ata/ata_if.m optional ata | atacore > dev/ata/ata-all.c optional ata | atacore > dev/ata/ata-lowlevel.c optional ata | atacore > dev/ata/ata-queue.c optional ata | atacore > +dev/ata/ata-dma.c optional ata | atadma > +dev/ata/ata-sata.c optional ata | atasata What is atadma and atasata here, kernel options? What for are they needed? You will not be able to build most of drivers without them, while enabling them for others will not give you any benefit, just bigger code size. I think dependency must be reviewed there. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A434F2C.1020005>