From owner-p4-projects@FreeBSD.ORG Sun Dec 14 21:24:27 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 85F021065675; Sun, 14 Dec 2008 21:24:27 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47E00106564A; Sun, 14 Dec 2008 21:24:27 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id E0A1C8FC08; Sun, 14 Dec 2008 21:24:26 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id mBELMAeI021818; Sun, 14 Dec 2008 14:22:10 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 14 Dec 2008 14:22:10 -0700 (MST) Message-Id: <20081214.142210.1102529432.imp@bsdimp.com> To: hselasky@freebsd.org From: "M. Warner Losh" In-Reply-To: <200812061000.mB6A0YwA051708@repoman.freebsd.org> References: <200812061000.mB6A0YwA051708@repoman.freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: perforce@freebsd.org Subject: Re: PERFORCE change 154172 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Dec 2008 21:24:27 -0000 In message: <200812061000.mB6A0YwA051708@repoman.freebsd.org> Hans Petter Selasky writes: : ==== //depot/projects/usb/src/sys/dev/usb/usbdevs#27 (text+ko) ==== : : @@ -811,6 +811,7 @@ : product ALCOR UMCR_9361 0x9361 USB Multimedia Card Reader : product ALCOR SM_KBD 0x9410 MicroConnectors/StrongMan Keyboard : product ALCOR NEC_KBD_HUB 0x9472 NEC Kbd Hub : +product ALCOR TRANSCEND 0x6387 Transcend JetFlash Drive This should be sorted by device id number. Also, it is product, not product Warner : /* Altec Lansing products */ : product ALTEC ADA70 0x0070 ADA70 Speakers : : ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#13 (text+ko) ==== : : @@ -818,6 +818,7 @@ : #define USB_PRODUCT_ALCOR_UMCR_9361 0x9361 /* USB Multimedia Card Reader */ : #define USB_PRODUCT_ALCOR_SM_KBD 0x9410 /* MicroConnectors/StrongMan Keyboard */ : #define USB_PRODUCT_ALCOR_NEC_KBD_HUB 0x9472 /* NEC Kbd Hub */ : +#define USB_PRODUCT_ALCOR_TRANSCEND 0x6387 /* Transcend JetFlash Drive */ : : /* Altec Lansing products */ : #define USB_PRODUCT_ALTEC_ADA70 0x0070 /* ADA70 Speakers */ : : ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#13 (text+ko) ==== : : @@ -653,6 +653,12 @@ : "NEC Kbd Hub", : }, : { : + USB_VENDOR_ALCOR, USB_PRODUCT_ALCOR_TRANSCEND, : + 0, : + "Alcor Micro", : + "Transcend JetFlash Drive", : + }, : + { : USB_VENDOR_ALTEC, USB_PRODUCT_ALTEC_ADA70, : 0, : "Altec Lansing", : : ==== //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#17 (text+ko) ==== : : @@ -400,6 +400,10 @@ : UMASS_PROTO_SCSI | UMASS_PROTO_BBB, : NO_GETMAXLUN : }, : + {USB_VENDOR_ALCOR, USB_PRODUCT_ALCOR_TRANSCEND, RID_WILDCARD, : + UMASS_PROTO_SCSI | UMASS_PROTO_BBB, : + NO_GETMAXLUN : + }, : {USB_VENDOR_ASAHIOPTICAL, USB_PRODUCT_ASAHIOPTICAL_OPTIO230, RID_WILDCARD, : UMASS_PROTO_SCSI | UMASS_PROTO_BBB, : NO_INQUIRY : @@ -636,10 +640,10 @@ : UMASS_PROTO_SCSI, : NO_GETMAXLUN : }, : - { USB_VENDOR_ONSPEC, USB_PRODUCT_ONSPEC_SDS_HOTFIND_D, RID_WILDCARD, : - UMASS_PROTO_SCSI | UMASS_PROTO_BBB, : - NO_GETMAXLUN | NO_SYNCHRONIZE_CACHE : - }, : + {USB_VENDOR_ONSPEC, USB_PRODUCT_ONSPEC_SDS_HOTFIND_D, RID_WILDCARD, : + UMASS_PROTO_SCSI | UMASS_PROTO_BBB, : + NO_GETMAXLUN | NO_SYNCHRONIZE_CACHE : + }, : {USB_VENDOR_ONSPEC, USB_PRODUCT_ONSPEC_CFMS_RW, RID_WILDCARD, : UMASS_PROTO_SCSI, : NO_QUIRKS :