From owner-cvs-all@FreeBSD.ORG Sat Jul 5 14:55:39 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2ACE0106566C; Sat, 5 Jul 2008 14:55:39 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 977008FC0C; Sat, 5 Jul 2008 14:55:38 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from kobe.laptop (adsl135-103.kln.forthnet.gr [77.49.254.103]) (authenticated bits=128) by igloo.linux.gr (8.14.3/8.14.3/Debian-4) with ESMTP id m65EtPlM027263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 5 Jul 2008 17:55:30 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.2/8.14.2) with ESMTP id m65EtOiA030206; Sat, 5 Jul 2008 17:55:24 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by kobe.laptop (8.14.2/8.14.2/Submit) id m65EtOQh030132; Sat, 5 Jul 2008 17:55:24 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) From: Giorgos Keramidas To: Gabor PALI References: <200807050224.m652OWW9021964@repoman.freebsd.org> <878wwhvvor.fsf@kobe.laptop> <486F1EEE.3050202@FreeBSD.org> Date: Sat, 05 Jul 2008 17:55:23 +0300 In-Reply-To: <486F1EEE.3050202@FreeBSD.org> (Gabor PALI's message of "Sat, 05 Jul 2008 09:12:46 +0200") Message-ID: <87lk0gidno.fsf@kobe.laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-MailScanner-ID: m65EtPlM027263 X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.757, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.64, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Spam-Status: No Cc: doc-committers@FreeBSD.org, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/faq book.sgml X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jul 2008 14:55:39 -0000 On Sat, 05 Jul 2008 09:12:46 +0200, Gabor PALI wrote: >> The suggestion about STRIP= and CFLAGS+='-g' is a bit old now too. > > I had the same suspicion (especially for STRIP), but it seems it managed > to escape our (my, gabor's and the reviewers') observation somehow. > >> cd /usr/src/usr.sbin/ppp env DEBUG_FLAGS='-g' make clean env >> DEBUG_FLAGS='-g' make install > > However, I think CFLAGS still can be used for inclusion of debug > symbols, although your env(1) based solution is a good (and very > elegant!) idea for ones who do not want to modify their /etc/make.conf > every time. CFLAGS with optimizations may cause 'bogus' tracebacks, because of function inlining or other optimization changes. It's usually a good idea to disable all optimizations when tracking down bugs with gdb(1), but that may be risky too. Some bugs only show when optimizations *are* enabled, and may turn to "Heisenbugs" when optimizations are disabled. Having said that, DEBUG_FLAGS doesn't override CFLAGS. It merely makes sure that: * CFLAGS includes the value of DEBUG_FLAGS. * No strip(1) run is done to remove debugging symbols. >> Does the following patch for this question look ok to you? > > Your version is very nice, I would be happy to add it to the FAQ. I > would like to ask doc committers (and FAQ patchletter reviewers) reading > this mail to review and comment on Giorgos' patch to have a third-party > review. > > Giorgos, would you approve my commit for this patch in advance? Sorry > for that, but I am actually a guest here :) Of course. Please feel free to commit it either "as is" or in a modified form. > PS: Hey, Giorgios, what about my checkupdate patches? Have you tried or > reviewed them? I already started to use them as you will see very soon :) I just started getting "back" from ${real_life}. I'm slowly catching up with email, but I will try to reply soon-ish about those. Thanks :)