Date: Mon, 28 Jun 2004 15:38:59 -0400 From: Brian Fundakowski Feldman <green@FreeBSD.org> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.c Message-ID: <20040628193858.GG5635@green.homeunix.org> In-Reply-To: <20040628152232.A2977@grasshopper.cs.duke.edu> References: <200406281915.i5SJFeaV060231@repoman.freebsd.org> <20040628152232.A2977@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 28, 2004 at 03:22:33PM -0400, Andrew Gallatin wrote:
> Andrew Gallatin [gallatin@FreeBSD.org] wrote:
> > gallatin 2004-06-28 19:15:40 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> > sys/vm vm_map.c
> > Log:
> > Fix alpha - the use of min() on longs was loosing the high bits and
> > returning wrong answers, leading to strange values vm2->vm_{s,t,d}size.
>
> Why are min() and max() inlines which operate on ints? This seems
> like a real landmine for 64-bit platforms..
Also, why is GCC not generating the correct warnings? The values passed
in were definitely a 64-bit type. Thanks for finding and fixing this.
The inlines seem to exist to work around the effect of using macros
unknowingly on statements with side effects. These should really be
MIN(), and there seems to have been an extra tab that crept in. Do
you think you could change those things?
--
Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\
<> green@FreeBSD.org \ The Power to Serve! \
Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040628193858.GG5635>