Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Apr 2019 18:40:22 +0000
From:      bugzilla-noreply@freebsd.org
To:        ppc@FreeBSD.org
Subject:   [Bug 233863] r345425 on PowerMac G5 may require kern.smp.disabled=1 and must set usefdt=1 which causes net interface reorder
Message-ID:  <bug-233863-21-M508EuMiTW@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-233863-21@https.bugs.freebsd.org/bugzilla/>
References:  <bug-233863-21@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233863

--- Comment #11 from Mark Millard <marklmi26-fbsd@yahoo.com> ---
(In reply to Mark Millard from comment #10)

The disabling of blocking duplicate paths in fdt_add_subnode_namelen
was done incorrectly. I'll replace the attachment after building
and testing. I think this is the explanation for the PowerMac11,2
shutdown -r or -p problems.

The code should have just disabled the return, more like:

        if (offset >=3D 0)
#if 0
// Some Macintoshes have identical package-to-pathname results for
// multiple nodes of the same type and unit under the parent node.
// Avoid blocking this for fdt.
                return -FDT_ERR_EXISTS;
#else
                ;
#endif
        else if (offset !=3D -FDT_ERR_NOTFOUND)
                return offset;

Instead the messed up change did the "return offset;" and
so did not do the addition of the node, instead returning
the pre-existing one to be manipulated.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233863-21-M508EuMiTW>