Date: Sun, 22 Feb 2015 15:16:32 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 197922] [patch] [sched] Remove random() from sched_ule, add short circuit for non-SMP, non-balancing Message-ID: <bug-197922-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197922 Bug ID: 197922 Summary: [patch] [sched] Remove random() from sched_ule, add short circuit for non-SMP, non-balancing Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: harrison.grundy@astrodoggroup.com Created attachment 153317 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153317&action=edit Replace random with get_cyclecount as a suitable source of entropy for the balancer. Short circuit for non-SMP/Balance As discovered by John-Mark Gurney, ULE uses random() which is not SMP/preemption safe. Move the check for SMP and Balancer being enabled above the generation of the balancing interval. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197922-8>