Date: Thu, 14 Jun 2018 05:10:21 -0700 From: Eitan Adler <eadler@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335042 - head/usr.bin/top Message-ID: <CAF6rxg=HnK7eRXS0=rW4jxZZTwK5hMbQCUVQy_d=YqQ6biECCg@mail.gmail.com> In-Reply-To: <9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9@FreeBSD.org> References: <201806130852.w5D8qKd4094584@repo.freebsd.org> <9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 June 2018 at 17:01, Bryan Drewery <bdrewery@freebsd.org> wrote: > On 6/13/2018 1:52 AM, Eitan Adler wrote: >> Author: eadler >> Date: Wed Jun 13 08:52:19 2018 >> New Revision: 335042 >> URL: https://svnweb.freebsd.org/changeset/base/335042 >> >> Log: >> top(1): add myself to authors >> >> At this point I've mucked enough with top(1) that all bugs should be >> blamed on me rather than William LeFebvre. >> > > Thank you for all of your work here... > > There's not exactly a guideline for this but I don't feel that > non-functional changes qualify as "authors". I actually meant what I wrote in the commit message: at this point it doesn't make sense to blame William. I'll revert the change to top.1 change as I don't care all that much. Personally, I like being liberal with credit though I understand that isn't the project's stance necessarily. > Especially the sorting chosen. I went with alphabetical. Perhaps I missed some rewrite you've done? Though none have > 'Relnotes: yes' so I am assuming they were all non-functional. Some were functional, I've not done a good job of marking them. > I do see some people adding their Copyright on some commits but overall > we haven't done that as a project and I am curious if we should change > in that regard. The rule of them is about 25% of the file, right? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=HnK7eRXS0=rW4jxZZTwK5hMbQCUVQy_d=YqQ6biECCg>