Date: Tue, 07 Oct 2003 14:12:06 -0400 From: blynn42@comcast.net (Brian Lynn) To: Erik Trulsson <ertr1013@student.uu.se> Cc: stable@freebsd.org Subject: Re: Strange error 4.9RC1 Message-ID: <200310071812.h97IC6RL039245@ted.wyld.stallyns> In-Reply-To: Your message of "Tue, 07 Oct 2003 02:30:53 %2B0200." <20031007003052.GA52906@falcon.midgard.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 07 Oct 2003 02:30:53 +0200, Erik Trulsson wrote: > On Mon, Oct 06, 2003 at 07:33:24PM -0400, Brian Lynn wrote: > > > > On Sun, 05 Oct 2003, Jack Raats wrote: > > <snip> > Or just cvsup to the latest RELENG_4 since the following commit was > made a short while ago: > > > imp 2003/10/05 19:53:52 PDT > FreeBSD src repository > Modified files: (Branch: RELENG_4) > sys/dev/ep if_ep_eisa.c if_ep_isa.c if_ep_mca.c > if_ep_pccard.c > sys/dev/ed if_ed_cbus.c if_ed_isa.c if_ed_pccard.c > if_ed_pci.c > Log: > Driver names for DRIVER_MODULE in current are 'ed' and 'ep', but in > -stable they need to be 'if_ed' and 'if_ep'. ifconfig should be > modified, but this is a lower risk change this late in the release > cycle. > Approved by: re@ > Note to self: Do not check cvsweb, wait 24hrs, THEN post <snip> > > but I don't really know what I'm doing - YMMV. > > > > --- sbin/ifconfig/ifconfig.c.orig Tue Jan 28 06:02:56 2003 > > +++ sbin/ifconfig/ifconfig.c Tue Sep 23 18:06:07 2003 > > @@ -1995,7 +1995,8 @@ > > cp = mstat.name; > > } > > /* already loaded? */ > > - if (!strcmp(ifkind, cp)) > > + /* if (!strcmp(ifkind, cp)) */ > > + if (!strncmp(name, cp, strlen(cp))) > > return; > > } > > } > > As far as I can tell, that patch will not work for those drivers that > *do* register as BUS/if_FOO instead of BUS/FOO. > In -CURRENT all the network drivers seem to have been changed at the > same time to register themselves as BUS/FOO rather than BUS/if_FOO so > there the patch should work, but I don't think it will work in -STABLE. > > Are you sure it works correctly for the 'xl' interface? (I.e. that if > you have the 'xl' driver in the kernel, ifconfig will not attempt to > load it as a module.) > ('lo' is not available as a module, so no problem there, and 'ed' > used the convention that this patch will make ifconfig use, so those > should work with the patch. (At least before the commit referenced > above which changes 'ed' to use the if_FOO style.) > Hmm... AFAICT, it does work. No complaints about "module_register" (or anything else) in the logs. After staring at it for a while, I wonder if the strncmp() above might be matching on miibus/xlphy? 12:20pm ted ~>kldstat Id Refs Address Size Name 1 3 0xc0100000 293610 kernel 2 1 0xc0cb7000 50000 nfs.ko 3 1 0xc0d2a000 15000 linux.ko 12:20pm ted ~>kldstat -v |grep xl 65 pci/if_xl 66 xl/miibus 73 miibus/xlphy If this is the case then I was simply lucky. Brian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200310071812.h97IC6RL039245>