Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 8 Sep 2012 22:16:14 GMT
From:      Jean-Sébastien Pédron <dumbbell@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/171478: [PATCH] multimedia/avidemux2: Fix default options selection
Message-ID:  <201209082216.q88MGEOr086364@red.freebsd.org>
Resent-Message-ID: <201209082220.q88MK2I9095973@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         171478
>Category:       ports
>Synopsis:       [PATCH] multimedia/avidemux2: Fix default options selection
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 08 22:20:02 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Jean-Sébastien Pédron
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
The FreeBSD Project
>Environment:
FreeBSD magellan.dumbbell.fr 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r240144M: Wed Sep  5 21:01:29 CEST 2012     root@magellan.dumbbell.fr:/usr/obj/home/dumbbell/Projects/freebsd/SVN/head/sys/MAGELLAN  amd64
>Description:
The following snippet in multimedia/avidemux2/Makefile.common seems incorrect:
  OPTIONS_DEFAULT= GTK2 FREETYPE FONTCONFIG OSS XVIDEO VPX XVID SDL FAAD VORBIS

  .if !defined(PACKAGE_BUILDING)
  OPTIONS_DEFAULT= LAME FAAC AMR
  .endif

The second "OPTIONS_DEFAULT=" overwrites the first one. I attached a patch that simply transforms it to a "OPTIONS_DEFAULT+=".
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: multimedia/avidemux2/Makefile.common
===================================================================
--- multimedia/avidemux2/Makefile.common	(revision 303913)
+++ multimedia/avidemux2/Makefile.common	(working copy)
@@ -41,7 +41,7 @@
 OPTIONS_DEFAULT=	GTK2 FREETYPE FONTCONFIG OSS XVIDEO VPX XVID SDL FAAD VORBIS
 
 .if !defined(PACKAGE_BUILDING)
-OPTIONS_DEFAULT=	LAME FAAC AMR
+OPTIONS_DEFAULT+=	LAME FAAC AMR
 .endif
 
 .include <bsd.port.pre.mk>


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209082216.q88MGEOr086364>