Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Jun 2018 12:07:45 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Devin Teske <dteske@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r472896 - in head/sysutils: . ssd_report
Message-ID:  <7fb99590-249d-0edb-cf43-c7f25a00f6cd@FreeBSD.org>
In-Reply-To: <201806201831.w5KIVl4G026127@repo.freebsd.org>
References:  <201806201831.w5KIVl4G026127@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--P0BT40gfjtersT2az12nprst10Cz61qCX
Content-Type: multipart/mixed; boundary="3clO3OmFTE818BhBn63rfJq3dk4MWlVCA";
 protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Devin Teske <dteske@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <7fb99590-249d-0edb-cf43-c7f25a00f6cd@FreeBSD.org>
Subject: Re: svn commit: r472896 - in head/sysutils: . ssd_report
References: <201806201831.w5KIVl4G026127@repo.freebsd.org>
In-Reply-To: <201806201831.w5KIVl4G026127@repo.freebsd.org>

--3clO3OmFTE818BhBn63rfJq3dk4MWlVCA
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 6/20/2018 11:31 AM, Devin Teske wrote:
> Author: dteske
> Date: Wed Jun 20 18:31:47 2018
> New Revision: 472896
> URL: https://svnweb.freebsd.org/changeset/ports/472896
>=20
> Log:
>   [New Port] sysutils/ssd_report
>  =20
>   Report SSD health by looking at SMART data. Supports `smartctl' from
>   sysutils/smartmontools but prefers `smart' from sysutils/smart. Also
>   supports JSON output upon request.
>  =20
>   Reviewed by:	mat (mentor)
>   Approved by:	portmgr (mat), mat (mentor)
>   Sponsored by:	Smule, Inc.
>   Differential Revision:	https://reviews.freebsd.org/D15876
>=20
> Added:
>   head/sysutils/ssd_report/
>   head/sysutils/ssd_report/Makefile   (contents, props changed)
>   head/sysutils/ssd_report/distinfo   (contents, props changed)
>   head/sysutils/ssd_report/pkg-descr   (contents, props changed)
> Modified:
>   head/sysutils/Makefile
>=20
> Modified: head/sysutils/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sysutils/Makefile	Wed Jun 20 18:25:02 2018	(r472895)
> +++ head/sysutils/Makefile	Wed Jun 20 18:31:47 2018	(r472896)
> @@ -1202,6 +1202,7 @@
>      SUBDIR +=3D spinner
>      SUBDIR +=3D spiped
>      SUBDIR +=3D squashfs-tools
> +    SUBDIR +=3D ssd_report
>      SUBDIR +=3D sshsudo
>      SUBDIR +=3D ssid
>      SUBDIR +=3D ssync
>=20
> Added: head/sysutils/ssd_report/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/ssd_report/Makefile	Wed Jun 20 18:31:47 2018	(r472896=
)
> @@ -0,0 +1,36 @@
> +# $FreeBSD$
> +
> +PORTNAME=3D	ssd_report
> +DISTVERSION=3D	0.2
> +CATEGORIES=3D	sysutils
> +
> +MAINTAINER=3D	dteske@FreeBSD.org
> +COMMENT=3D	SSD health report
> +
> +LICENSE=3D	BSD2CLAUSE
> +LICENSE_FILE=3D	${WRKSRC}/LICENSE
> +
> +FLAVORS=3D	smart smartmontools

FLAVORS requires that each flavor has a unique PKGNAME because *every
version of the package* will be built and stored on the package
repository. It can't work to have 2 packages with the same name that
have different functionality. So you must handle PKGNAMESUFFIX here
somehow for at least the non-default flavors.

smartmontools_PKGNAMESUFFIX=3D -smartmontools


> +FLAVOR?=3D	${FLAVORS:[1]}

Why put FLAVOR? here? It is not needed. FLAVOR is a user-specified
option that already has a default in bsd.port.mk.

> +
> +smart_RUN_DEPENDS=3D		smart:sysutils/smart
> +smartmontools_RUN_DEPENDS=3D	smartctl:sysutils/smartmontools
> +
> +USE_GITHUB=3D	yes
> +GH_ACCOUNT=3D	FrauBSD
> +NO_ARCH=3D	yes
> +NO_BUILD=3D	yes
> +
> +PLIST_FILES=3D	sbin/ssd_report
> +PORTDOCS=3D	README.md
> +
> +OPTIONS_DEFINE=3D	DOCS
> +
> +do-install:
> +	${INSTALL_SCRIPT} ${WRKSRC}/ssd_report ${STAGEDIR}${PREFIX}/sbin
> +
> +do-install-DOCS-on:
> +	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> +	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
> +
> +.include <bsd.port.mk>
>=20
> Added: head/sysutils/ssd_report/distinfo
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/ssd_report/distinfo	Wed Jun 20 18:31:47 2018	(r472896=
)
> @@ -0,0 +1,3 @@
> +TIMESTAMP =3D 1529303779
> +SHA256 (FrauBSD-ssd_report-0.2_GH0.tar.gz) =3D a56a76277dc095ef24dd954=
447e6ad86140838308e667d6143a84202a8c17f2c
> +SIZE (FrauBSD-ssd_report-0.2_GH0.tar.gz) =3D 7715
>=20
> Added: head/sysutils/ssd_report/pkg-descr
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/ssd_report/pkg-descr	Wed Jun 20 18:31:47 2018	(r47289=
6)
> @@ -0,0 +1,5 @@
> +Report SSD health by looking at SMART data. Supports `smartctl' from
> +sysutils/smartmontools but prefers `smart' from sysutils/smart. Also
> +supports JSON output upon request.
> +
> +WWW: https://fraubsd.org/ssd_report/
>=20


--=20
Regards,
Bryan Drewery


--3clO3OmFTE818BhBn63rfJq3dk4MWlVCA--

--P0BT40gfjtersT2az12nprst10Cz61qCX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJbKqYBAAoJEDXXcbtuRpfPa4cH/Ahsx2nBybmECkna5nS412i5
pOv4vKtmcTVB/z4D4Myg4BoNo1wR4UBRawRiI05l8/jgq/Fp8h+ozguPYikpUzmf
uJIn0fDqcPtXo82RHRUmQdExkYO7M87ECBP5JEGIQxm1EQ2+HnL+f0dBuElUOrwC
02AFL91+T5+ArzGqihgz0t8TrVKFhE3xQNFCV3MqjIrjy0WjGiL19RKjMft2mqo1
K06Ux+7D5ry7B0kfLZVHD8Cn1koBy47Hee2dhdkvsoNx+JH8BVrstr7OvUcgCzfN
zY7oSSJnQaKSOtGyqE/gjXJtFiBCejFv6X20ErnVkyH5vQ9ULVXSn1T7G/Hwkmw=
=M+oa
-----END PGP SIGNATURE-----

--P0BT40gfjtersT2az12nprst10Cz61qCX--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7fb99590-249d-0edb-cf43-c7f25a00f6cd>