Date: Wed, 22 May 2013 21:26:09 +0200 From: Christian Weisgerber <naddy@mips.inka.de> To: Chris Rees <utisoft@gmail.com> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r318777 - head/audio/libvorbis Message-ID: <20130522192609.GA24645@lorvorc.mips.inka.de> In-Reply-To: <CADLo83_p=ZH8X7_tugsTc_B%2B4HGwD4arFNisUoshk98LMwpMTA@mail.gmail.com> References: <201305221529.r4MFT9jr046442@svn.freebsd.org> <CADLo83_p=ZH8X7_tugsTc_B%2B4HGwD4arFNisUoshk98LMwpMTA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Chris Rees: > > +OPTIONS_DEFINE= DOCS > > Please don't do this; no-one needs an OPTIONS dialog jumping up for > something that should be set globally. > > You don't need DOCS, EXAMPLES, or NLS in OPTIONS_DEFINE if they're the only > ones used by the port. There are plenty of ports with OPTIONS_DEFINE=DOCS and no further options. I changed it (against my personal preference!), because it looked like this was the new way. So what *is* the consensus now? Either way, the Porter's Handbook is vague. -- Christian "naddy" Weisgerber naddy@mips.inka.de
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130522192609.GA24645>