From owner-p4-projects@FreeBSD.ORG  Sat Aug 23 09:55:45 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4C92C1065676; Sat, 23 Aug 2008 09:55:45 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0F7831065673
	for <perforce@FreeBSD.org>; Sat, 23 Aug 2008 09:55:45 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id F0F418FC1F
	for <perforce@FreeBSD.org>; Sat, 23 Aug 2008 09:55:44 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7N9tiGr064702
	for <perforce@FreeBSD.org>; Sat, 23 Aug 2008 09:55:44 GMT
	(envelope-from hselasky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7N9tirJ064700
	for perforce@freebsd.org; Sat, 23 Aug 2008 09:55:44 GMT
	(envelope-from hselasky@FreeBSD.org)
Date: Sat, 23 Aug 2008 09:55:44 GMT
Message-Id: <200808230955.m7N9tirJ064700@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	hselasky@FreeBSD.org using -f
From: Hans Petter Selasky <hselasky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 148161 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Aug 2008 09:55:45 -0000

http://perforce.freebsd.org/chv.cgi?CH=148161

Change 148161 by hselasky@hselasky_laptop001 on 2008/08/23 09:55:03

	
	Use snprintf instead of sprintf.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb2/storage/ustorage2_fs.c#7 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb2/storage/ustorage2_fs.c#7 (text+ko) ====

@@ -983,7 +983,11 @@
 	buf[4] = 31;
 	/* Additional length */
 	/* No special options */
-	sprintf(buf + 8, "%-8s%-16s%04x", vendor_id, product_id,
+	/*
+	 * NOTE: We are writing an extra zero here, that is not
+	 * transferred to the peer:
+	 */
+	snprintf(buf + 8, 28 + 1, "%-8s%-16s%04x", vendor_id, product_id,
 	    USTORAGE_FS_RELEASE);
 	return (ustorage_fs_min_len(sc, 36, 0 - 1));
 }