Date: Thu, 18 Sep 2008 13:15:10 +0400 From: Eygene Ryabinkin <rea-fbsd@codelabs.ru> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: rik@freebsd.org, hackers@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/127446: [patch] fix race in sys/dev/kbdmux/kbdmux.c Message-ID: <OukumQcOIGlPdbI1QmdweY8cFsk@IW4pzQfcswHj%2B/3imThIGjvxQdw> In-Reply-To: <OBTLESaczqaewZBU9qdf0FWZRHE@7/OI9n2WwGs0JPogavdPqCpU9P8> References: <20080917161633.9E2F717101@shadow.codelabs.ru> <bb4a86c70809170956x36234893he8894a49127b6b6e@mail.gmail.com> <gaH7cu1zt0Bw5e8Q2XfgrlKSRyY@iXA9ZWPrtc2I2BMzBXoToMd7YdQ> <bb4a86c70809171052t5e961675n139b2848e6addd0@mail.gmail.com> <OBTLESaczqaewZBU9qdf0FWZRHE@7/OI9n2WwGs0JPogavdPqCpU9P8>
next in thread | previous in thread | raw e-mail | index | archive | help
--Osvg0bgWkLaeQPMj
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Me again.
Thu, Sep 18, 2008 at 11:10:17AM +0400, Eygene Ryabinkin wrote:
> OK, I had tried substituting KBDMUX_LOCK/UNLOCK with Giant operations --
> it works as expected.
Tried my initial patch on some 7.0-PRERELEASE -- it locks keyboard when
geli asks for the password. Had not much time to dig it out, will try
to do it as soon as I can. Substituting KBDMUX_LOCK/UNLOCK with Giant
locking helps even on this FreeBSD version.
More testing needed, may be there are some other issues that aren't
revealing themselves...
--=20
Eygene
_ ___ _.--. #
\`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard
/ ' ` , __.--' # to read the on-line manual =20
)/' _/ \ `-_, / # while single-stepping the kernel.
`-'" `"\_ ,_.-;_.-\_ ', fsc/as #
_.-'_./ {_.' ; / # -- FreeBSD Developers handbook=20
{_.-``-' {_/ #
--Osvg0bgWkLaeQPMj
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)
iEYEARECAAYFAkjSHB4ACgkQthUKNsbL7YioXQCdFW6oiOEMnP3H1H7GottuoSVM
4xEAoJszdX8jUpmfbXxXd9Yy2Bms7K39
=Qchb
-----END PGP SIGNATURE-----
--Osvg0bgWkLaeQPMj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?OukumQcOIGlPdbI1QmdweY8cFsk>