From owner-freebsd-stable@FreeBSD.ORG Thu Aug 15 21:18:14 2013 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B526F71; Thu, 15 Aug 2013 21:18:14 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from aussmtpmrkpc120.us.dell.com (aussmtpmrkpc120.us.dell.com [143.166.82.159]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 510BE2A4A; Thu, 15 Aug 2013 21:18:13 +0000 (UTC) X-Loopcount0: from 64.238.244.148 X-IronPort-AV: E=Sophos;i="4.89,888,1367989200"; d="scan'208";a="40146243" Message-ID: <520D458E.4070801@vangyzen.net> Date: Thu, 15 Aug 2013 16:18:06 -0500 From: Eric van Gyzen User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130702 Thunderbird/17.0.7 MIME-Version: 1.0 To: Glen Barber , stable@freebsd.org Subject: Re: makefs Sparse Files: NetBSD CLI Compatibility References: <520B81D1.1010500@vangyzen.net> <20130814140653.GG2241@glenbarber.us> <520B951D.2080305@vangyzen.net> <20130814145345.GI2241@glenbarber.us> <520B9EA5.5010107@vangyzen.net> In-Reply-To: <520B9EA5.5010107@vangyzen.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Simon Gerraty X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2013 21:18:14 -0000 On 08/14/2013 10:13, Eric van Gyzen wrote: > On 08/14/2013 09:53, Glen Barber wrote: >> On Wed, Aug 14, 2013 at 09:33:01AM -0500, Eric van Gyzen wrote: >>> On 08/14/2013 09:06, Glen Barber wrote: >>>> On Wed, Aug 14, 2013 at 08:10:41AM -0500, Eric van Gyzen wrote: >>>>> NetBSD's makefs has a -Z flag to create the image as a sparse file. In >>>>> FreeBSD, the flag is spelled -p. Is there a reason for using a >>>>> different flag? It would be very nice to preserve CLI compatibility >>>>> with NetBSD. >>>>> >>>>> NetBSD committed first (by one month), and neither change has gone into >>>>> a release yet, so we should change to match NetBSD. We should do it >>>>> soon, too, since our change will go into 9.2-RELEASE. >>>>> >>>>> If we agree, I'll gladly make the patches, trivial though they'll be. >>>>> >>>> Can you please try the attached patch? >>> Thanks, Glen. That patch would work. However, since our -p flag has >>> not yet gone into a release, there is no need to keep it. I suggest >>> that we simply rename -p to -Z, to match NetBSD. The attached patch >>> does this. >>> >> Not in a release, no, but it is available in stable/ branches. I'd >> prefer to deprecate the '-p' but keep the option for now, as we have no >> way to know how many people are using it. > That's reasonable. The attached patch, for releng/9.2, does this. We > could remove -p in head (by using my previous patch). Is there any chance this will be fixed in 9.2? It would be nice to avoid introducing incompatibility in a release. Eric