From owner-svn-ports-all@freebsd.org Thu Jun 25 18:14:09 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3BD7F98D7AD; Thu, 25 Jun 2015 18:14:09 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-wi0-x22c.google.com (mail-wi0-x22c.google.com [IPv6:2a00:1450:400c:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C717B14CE; Thu, 25 Jun 2015 18:14:08 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by wiga1 with SMTP id a1so171932714wig.0; Thu, 25 Jun 2015 11:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=yDEXcN48KJPAJ4ReaIFWD2c/45WudQohgAjftK9zvCo=; b=s9mKNI3rinmj9C6JFs6i3CTpqeDQa6hgPA5lj6lPm45RW0P2RaTOSjgZqwM52czQU7 isErBavc9kzxEyWHMLw6S+RkRA7+LEwQcGJWpF3TWVMcluylI6VpwFZz6RvFnbDVV/7j VRqk8Q1nsaJN9nURU2Rl0+uWDW/DTkB6ufoRmodE5kkrkbtCaxu7bHbH9cgPQbgrr8oA Iwlbg3tf3Z1oqjRKQECdEGGg7M8Lq8H/mnIvWyqnsKkzeaMz6eIKGpMnxOCd41yAkqWq uOWJ3T7X5lP8QvadgCPSeZ0R3YHBcRrUoJ4jttcOqtrYgcqbScM0EsszTihCRQ9Ktxbw e4jQ== MIME-Version: 1.0 X-Received: by 10.195.13.1 with SMTP id eu1mr17070437wjd.131.1435256047176; Thu, 25 Jun 2015 11:14:07 -0700 (PDT) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.194.17.130 with HTTP; Thu, 25 Jun 2015 11:14:07 -0700 (PDT) In-Reply-To: References: <201506251653.t5PGrWUb082817@svn.freebsd.org> Date: Thu, 25 Jun 2015 20:14:07 +0200 X-Google-Sender-Auth: LKKVDEIsnEI94vaZqua8AFUrL7g Message-ID: Subject: Re: svn commit: r390588 - in head: net/luasocket textproc/luaexpat From: Antoine Brodin To: Sunpoet Hsieh Cc: "ports-committers@freebsd.org" , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2015 18:14:09 -0000 On Thu, Jun 25, 2015 at 8:06 PM, Sunpoet Hsieh wrote: > On Fri, Jun 26, 2015 at 12:53 AM, Antoine Brodin > wrote: >> >> Author: antoine >> Date: Thu Jun 25 16:53:31 2015 >> New Revision: 390588 >> URL: https://svnweb.freebsd.org/changeset/ports/390588 >> >> Log: >> Switch back to lua 5.1, the two consumers of those ports >> (audio/lua51-mpd >> and net-im/prosody) need it >> >> Pointy hat: sunpoet >> >> Modified: >> head/net/luasocket/Makefile >> head/textproc/luaexpat/Makefile >> >> Modified: head/net/luasocket/Makefile >> >> ============================================================================== >> --- head/net/luasocket/Makefile Thu Jun 25 16:52:55 2015 (r390587) >> +++ head/net/luasocket/Makefile Thu Jun 25 16:53:31 2015 (r390588) >> @@ -16,7 +16,7 @@ GH_ACCOUNT= diegonehab >> GH_TAGNAME= v3.0-rc1 >> >> MAKE_ARGS= LUA_VER=${LUA_VER} >> -USES= lua gmake pkgconfig >> +USES= lua:51 gmake pkgconfig >> >> CFLAGS+= `pkgconf --cflags lua-${LUA_VER}` >> LDFLAGS+= -shared `pkgconf --libs lua-${LUA_VER}` >> >> Modified: head/textproc/luaexpat/Makefile >> >> ============================================================================== >> --- head/textproc/luaexpat/Makefile Thu Jun 25 16:52:55 2015 >> (r390587) >> +++ head/textproc/luaexpat/Makefile Thu Jun 25 16:53:31 2015 >> (r390588) >> @@ -13,7 +13,7 @@ COMMENT= LuaExpat is a SAX XML parser ba >> >> LIB_DEPENDS= libexpat.so:${PORTSDIR}/textproc/expat2 >> >> -USES= gmake lua >> +USES= gmake lua:51 >> ALL_TARGET= lib >> CFLAGS+= -DLUA_INT_LONG >> >> > > Hi, > > Bapt done lots of work to convert USE_LUA to USES=lua. > IIRC, most of them are USES=lua:51. > We need to relax them to USES=lua if they work fine with lua52 or lua53. > > In this case, they build fine with lua52 and lua53. > I think the correct fix should be: > - audio/lua51-mpd: replace USES=lua:51 with USES=lua (and rename this port > to lua-mpd). > - net-im/prosody: replace USES=lua:51 in security/luasec/Makefile with > USES=lua. > > Can you revert this and change USES=lua:51 to USES=lua for audio/lua51-mpd > and security/luasec? I won't revert since it breaks the 2 ports mentioned above. Cheers, Antoine