From owner-cvs-all@FreeBSD.ORG  Sun Sep  5 21:58:31 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8B76416A4CE
	for <cvs-all@FreeBSD.org>; Sun,  5 Sep 2004 21:58:31 +0000 (GMT)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EF5AB43D53
	for <cvs-all@FreeBSD.org>; Sun,  5 Sep 2004 21:58:30 +0000 (GMT)
	(envelope-from andre@freebsd.org)
Received: (qmail 26460 invoked from network); 5 Sep 2004 21:55:29 -0000
Received: from unknown (HELO freebsd.org) ([62.48.0.54])
          (envelope-sender <andre@freebsd.org>)
          by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
          for <glebius@FreeBSD.org>; 5 Sep 2004 21:55:29 -0000
Message-ID: <413B8C06.CBC43282@freebsd.org>
Date: Sun, 05 Sep 2004 23:58:30 +0200
From: Andre Oppermann <andre@freebsd.org>
X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U)
X-Accept-Language: en
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>
References: <200409052006.i85K6ovn042219@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet ip_fw2.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Sep 2004 21:58:31 -0000

Gleb Smirnoff wrote:
> 
> glebius     2004-09-05 20:06:50 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/netinet          ip_fw2.c
>   Log:
>   Recover normal behavior: return EINVAL to attempt to add a divert rule
>   when module is built without IPDIVERT.
> 
>   Silence from:   andre
>   Approved by:    julian (mentor)

Thanks.  I was at the SUCON'04 the last days and only infrequently checking
my inbox.  The ipfw2 code never returned EINVAL for divert actions when the
IPDIVERT was not compiled in.  I didn't change that with the conversion to
pfil_hooks.

-- 
Andre