From owner-svn-src-all@FreeBSD.ORG Sat Feb 28 12:41:30 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 18480D5B; Sat, 28 Feb 2015 12:41:30 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E4D0AB2; Sat, 28 Feb 2015 12:41:29 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id AA902B94A; Sat, 28 Feb 2015 07:41:28 -0500 (EST) From: John Baldwin To: "David E. O'Brien" Subject: Re: svn commit: r279381 - head/sys/boot/amd64/efi Date: Sat, 28 Feb 2015 07:31:15 -0500 Message-ID: <1817281.ovAgFISPXy@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: <201502272222.t1RMM6rX042414@svn.freebsd.org> References: <201502272222.t1RMM6rX042414@svn.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Sat, 28 Feb 2015 07:41:28 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Feb 2015 12:41:30 -0000 On Friday, February 27, 2015 10:22:06 PM David E. O'Brien wrote: > Author: obrien > Date: Fri Feb 27 22:22:05 2015 > New Revision: 279381 > URL: https://svnweb.freebsd.org/changeset/base/279381 > > Log: > Use sys/boot/userboot/libstand/ and not /usr/lib/libstand.a. > > Modified: > head/sys/boot/amd64/efi/Makefile Ugh, this is wrong, please revert. For one, I just ran into a bug where the EFI bits are prone to random corruption because the EFI ABI doesn't use a redzone like the System V amd64 ABI. userboot is a C program though and will use the System V ABI, so it can't share libstand with loader.efi. Locally I have changed /usr/lib/libstand on amd64 to use -mno-red-zone as loader.efi is the only thing on amd64 that uses it (so this avoids mixing the ABIs). Also, if anything this should be using the lib/libstand from OBJDIR as that is what other loader binaries do. -- John Baldwin