From owner-freebsd-ports-bugs@freebsd.org Fri Jun 12 13:20:27 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3A0FD33A26F for ; Fri, 12 Jun 2020 13:20:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 49k1Yl0sf2z4VX3 for ; Fri, 12 Jun 2020 13:20:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 1BE3933A26D; Fri, 12 Jun 2020 13:20:27 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1BA9133A4CF for ; Fri, 12 Jun 2020 13:20:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49k1Yk6nCFz4Vwc for ; Fri, 12 Jun 2020 13:20:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E4252A0EF for ; Fri, 12 Jun 2020 13:20:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 05CDKQUU044868 for ; Fri, 12 Jun 2020 13:20:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 05CDKQB1044867 for ports-bugs@FreeBSD.org; Fri, 12 Jun 2020 13:20:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 247204] sysutils/bastille has incorrect default configuration file handling Date: Fri, 12 Jun 2020 13:20:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: paul@gromit.dlib.vt.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2020 13:20:27 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247204 Bug ID: 247204 Summary: sysutils/bastille has incorrect default configuration file handling Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: paul@gromit.dlib.vt.edu CC: christer.edwards@gmail.com Flags: maintainer-feedback?(christer.edwards@gmail.com) CC: christer.edwards@gmail.com The sysutils/bastille port uses @sample in pkg-plist to designate its defau= lt configuration file. However, it lists the "target_file" name, not the "sample_file" name. This causes any local modifications to /usr/local/etc/bastille/bastille.conf to be overwritten when the package is updated. A suggested fix is to change the config file pkg-plist entry to the followi= ng: @sample %%ETCDIR%%/bastille.conf.sample and to rename the distribution file in the port "bastille.conf.sample". Note, in Example 8.3 "Real Life Example, How @sample is Implemented" in the FreeBSD Porter's Handbook (https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-k= eywords.html#plist-keywords-sample-example) it's clear that if only one filename is present in a @sample line then the = real target file is assumed to be that filename minus the ".sample" suffix: ''target_file=3D"${sample_file%.sample}"'' This is also stated in Section = 8.6.9 ("@sample file [file]"), though the language wording is not 100% clear. Section 8.3 ("Configuration Files") is clear in recommending the single-filename variant of @sample, using ".sample" as the suffix. The Bastille port should be changed to adhere with this recommendation. --=20 You are receiving this mail because: You are the assignee for the bug.=