From owner-svn-src-all@freebsd.org Fri Apr 14 20:33:40 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 19E2BD3A6C9; Fri, 14 Apr 2017 20:33:40 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x242.google.com (mail-pg0-x242.google.com [IPv6:2607:f8b0:400e:c05::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D7ABF1BE6; Fri, 14 Apr 2017 20:33:39 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x242.google.com with SMTP id o123so17792320pga.1; Fri, 14 Apr 2017 13:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=ScsIUx0yl2WRPiXfY9B8lhBsRrBh7N01AuMlX7XjJZA=; b=QDD86mMtmGUMM63Gk3JUy/7PSA/2w2KFxDjOfEoToSczKZRV5A5VPnQcDM4yCh1OUf 81LSMNHNZp1KtkoMgCVRV172S4EAFONG+/6FGD1HUPiVAnVLjGjUGaRFIUNFu2Vrbl8r JXXKUxcqsbmrNviFtvdgfkwDqH9HBWlAq2/BV1sA2tIMD7k4gV2RGokLVIKG2sddbtJ0 iIVNQJrir9cPTRiQptebSc4i7rCinbyI4zbCtTp2wamY3NyBJQVGnK2bX2Qt0bsPHX9p CsV5DDYTcCdKVePVZZhfUFYU/0SOckjizhHvuQwbXbdKBCySvRGHH4Jd/nEXiiucdXUo aCjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=ScsIUx0yl2WRPiXfY9B8lhBsRrBh7N01AuMlX7XjJZA=; b=Rv5j0HFOHpJiSddPKFgdtttCOoBPPFBLTpYJoywqi+3MeT+bhfA1iw5WwFfpgrImG9 hIgpRajh2Cigq/QlqyrOtTl/6MW9A48+CcRXSh2C9Rxa9Rkhvil86pmU1f6T3Sjhd8cM MlY7fZYr5aJSrbVMRUaptEXhSJ1JVQLRgsva2yTqc+XOEHhG9q1PiSxxdCLBY37eKTxZ NIWyLui28CgxWU04X6nz0FotKdIeyOTXRY2YsT5gcomc1UFV8l7kDzm1FPAbGNda32ck Eyk75ozVBwcbPSBCaWj0qJgIEhPas3wzCaVPQJu2ekfogq37c3jmoKdHBzd+vsh+VPID tXaQ== X-Gm-Message-State: AN3rC/6VIu1U3/ddiIO73QKcXn6s1JGYH6pKEgsz/EuiFoeAbQt+9pFU +xWsDHrV+v0L7A== X-Received: by 10.84.224.73 with SMTP id a9mr11219074plt.38.1492202019371; Fri, 14 Apr 2017 13:33:39 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id p2sm4762491pfj.93.2017.04.14.13.33.37 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Apr 2017 13:33:38 -0700 (PDT) Subject: Re: svn commit: r316938 - head/sbin/savecore Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_C790D917-BF6F-4C2A-8142-67B1435377E7"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <0CAE4B1C-228B-4C71-86E9-4337753DFF74@lerctr.org> Date: Fri, 14 Apr 2017 13:33:36 -0700 Cc: Slawa Olhovchenkov , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Ngie Cooper , Alan Somers Message-Id: References: <201704141941.v3EJfmCW003347@repo.freebsd.org> <20170414201431.GF20974@zxy.spb.ru> <0CAE4B1C-228B-4C71-86E9-4337753DFF74@lerctr.org> To: Larry Rosenman X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 20:33:40 -0000 --Apple-Mail=_C790D917-BF6F-4C2A-8142-67B1435377E7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 14, 2017, at 13:26, Larry Rosenman wrote: >=20 > On 4/14/17, 3:19 PM, "Ngie Cooper (yaneurabeya)" = = wrote: >=20 >> On Apr 14, 2017, at 13:14, Slawa Olhovchenkov wrote: >>=20 >> On Fri, Apr 14, 2017 at 01:49:51PM -0600, Alan Somers wrote: >>=20 >>> On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper = wrote: >>>> Author: ngie >>>> Date: Fri Apr 14 19:41:48 2017 >>>> New Revision: 316938 >>>> URL: https://svnweb.freebsd.org/changeset/base/316938 >>>>=20 >>>> Log: >>>> savecore: fix space calculation with respect to `minfree` in = check_space(..) >>>>=20 >>>> - Use strtoll(3) instead of atoi(3), because atoi(3) limits the >>>> representable data to INT_MAX. Check the values received from >>>> strtoll(3), trimming trailing whitespace off the end to maintain >>>> POLA. >>>> - Use `KiB` instead of `kB` when describing free space, total = space, >>>> etc. I am now fully aware of `KiB` being the IEC standard for = 1024 >>>> bytes and `kB` being the IEC standard for 1000 bytes. >>>> - Store available number of KiB in `available` so it can be more >>>> easily queried and compared to ensure that there are enough KiB = to >>>> store the dump image on disk. >>>> - Print out the reserved space on disk, per `minfree`, so end-users >>>> can troubleshoot why check_space(..) is reporting that there = isn't >>>> enough free space. >>>>=20 >>>> MFC after: 7 weeks >>>> Reviewed by: Anton Rang (earlier diff), cem = (earlier diff) >>>> Tested with: positive/negative cases (see review); make tinderbox >>>> Sponsored by: Dell EMC Isilon >>>> Differential Revision: D10379 >>>=20 >>> The free space calculation is still uselessly conservative, because = it >>> doesn't account for the fact that core dumps will always be either >>> spare or compressed. The result is that savecore will frequently >>> refuse to save corefiles even when there's plenty of space. I >>> proposed removing the space check altogether in >>> https://reviews.freebsd.org/D2587. However, I agreed to wait until >>> after the compressed core dump feature was merged, because then = mostly >>> accurate space checks will be possible. AFAIK the compressed core >>> dump feature still hasn't been finished. >>=20 >> Is posible (in the future) to use multiple swaps (on multiple disks) >> for save core dumps? >=20 > Multiple swap devices is already handled by savecore(8), if one = uses fstab(5) or dumpon(8). Otherwise, you must invoke savecore(8) on = individual devices. >=20 > As far as saving to multiple disks is concerned, I would hope that = one is using a redundancy capable filesystem (zfs) or RAID-like = technology (gmirror, graid, LSI Fusion=E2=80=99s RAID product line) to = stripe and/or mirror the data across multiple disks. =E2=80=A6 > How do I use multiple devices to have the system dump on all of my = swap? I got a message about not enough space, but there (I think) was = enough between multiple drives=E2=80=A6. Something like: - Create a zpool - Mount zpool to /crashdumps - Change dumpdir in /etc/rc.conf to be /crashdumps, e.g., echo = =E2=80=98dumpdir=3D/crashdumps=E2=80=99 ? HTH, -Ngie PS The issue with lack of space might be the issue that Alan brought up = earlier with compressed dumps and overly conservative free space checks, = or it might be the fact that dumpdir (default: /var/crash) is full. --Apple-Mail=_C790D917-BF6F-4C2A-8142-67B1435377E7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8TIhAAoJEPWDqSZpMIYVLx0P/iUXgYmmooUe4Wxn+Pml9V5g kXBFrlo082lBIiz+YYkUdwyt4jdthXgminrGzugXmpXdWalB3GbLL9m76z2CCQ85 IJ6HBpyWUs918P7I0yhA4YnXCXVwP9cbcsdBcpMQH6bVDGE0slncJdMqtsYqItpo eHd03Bmw+6F+J+wh1Ysh1lo3gfHWW6HpKi4Q8R4oWInODH8Nz2d7U6YAlSu9udMo Plt2grjGsCqwfiz6ZY6/zC3cjFmB8LnVlcKmjprri7eM1RWdiqiXYpHxDKGHOjgs DAEmNMTf3wXUKQlKEF4GyTN1Nb6Q033v/LHi7JbDD56f+A7MHy0+MaPMMcx31IAI HGIicG8cpdhKkt9SOsENfN3aw/7UlNjdyKchWUS1dQrvaf1GcOqP7eZW34F0f7Se 2VOG4YPUsEBVTPA9nM5APvHVlEiDikpx5KSg1cSg4feB0fJBbGgQZcqUi4Fynasn yrFWlary8j3FSjStDMGd+vgXl75m7RwBpIY7IZyuELODDCGRyeHzE6PXOlPDDfOw oZPeSxSpbH3qvGuevgiZQpshttGo7koeIl1so7SM9PDWRzIFlXo0yajAGcF5rgVR WUzbeMoqkPPv3iJU3OqxPz4H6N1O8OJ2kic1TFqQpXZ+nyVxq2zCmCaQTAdNi/TZ +zIlkOp5WrlJh/g00GPs =SxUU -----END PGP SIGNATURE----- --Apple-Mail=_C790D917-BF6F-4C2A-8142-67B1435377E7--