From owner-cvs-all@FreeBSD.ORG  Mon Nov 29 07:51:25 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id AD0DA106566B; Mon, 29 Nov 2010 07:51:25 +0000 (UTC)
Date: Mon, 29 Nov 2010 07:51:25 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: wen heping <wenheping@gmail.com>
Message-ID: <20101129075125.GA58770@FreeBSD.org>
References: <201011290629.oAT6TD4u084226@repoman.freebsd.org>
	<20101129071448.GA56903@FreeBSD.org>
	<AANLkTik-EKAcHxOzEM=p0CxwvVDyaCbcA5n+LfA3i+R_@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <AANLkTik-EKAcHxOzEM=p0CxwvVDyaCbcA5n+LfA3i+R_@mail.gmail.com>
User-Agent: Mutt/1.4.2.1i
Cc: Wen Heping <wen@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: cvs commit: ports/Mk bsd.python.mk ports/lang/python27 Makefile
	distinfo pkg-plist ports/lang/python27/files
	patch-Lib-test-test_socket.py patch-Lib-test-test_threading.py
	patch-Lib_test_test_threading.py
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Nov 2010 07:51:25 -0000

On Mon, Nov 29, 2010 at 03:21:37PM +0800, Wen Heping wrote:
> 2010/11/29 Alexey Dokuchaev <danfe@freebsd.org>:
> > On Mon, Nov 29, 2010 at 06:29:13AM +0000, Wen Heping wrote:
> >> wen     2010-11-29 06:29:13 UTC
> >>
> >>  Added files:
> >>   patch-Lib-test-test_threading.py
> >>  Removed files:
> >>   patch-Lib_test_test_threading.py
> >
> > Can you explain why this patch was renamed? "Beautifying" the name in
> > this case does not warrant the repo churn.
> 
> Previous patch could not patch cleanly and I created a new one.
> When I created it I named it as other patches in this port.
> 
> Should it be forced use the previous name ?

My point is that once file is in CVS, we should try to use it even if
the name is not perfectly in line with standard scheme.  The rationale
behind this rule is roughly the same as why we are not renaming existing
`patch-xy' patches or patches containing ::, for example.

If existing patch name looks good enough (and it obviously does, since
the file name is essentially the same), I think you should have not
created new file (regardless of the contents).

./danfe