Date: Mon, 20 Mar 2000 02:44:50 -0800 (PST) From: Poul-Henning Kamp <phk@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/alpha/alpha machdep.c vm_machdep.c src/sys/cam cam_periph.c src/sys/cam/scsi scsi_cd.c scsi_da.c scsi_pt.c scsi_sa.c scsi_target.c src/sys/contrib/dev/fla fla.c src/sys/contrib/softupdates ffs_softdep.c src/sys/dev/amr amr.c ... Message-ID: <200003201044.CAA45049@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
phk 2000/03/20 02:44:50 PST Modified files: sys/alpha/alpha machdep.c vm_machdep.c sys/cam cam_periph.c sys/cam/scsi scsi_cd.c scsi_da.c scsi_pt.c scsi_sa.c scsi_target.c sys/contrib/dev/fla fla.c sys/contrib/softupdates ffs_softdep.c sys/dev/amr amr.c sys/dev/ata ata-disk.c atapi-cd.c atapi-fd.c atapi-tape.c sys/dev/ccd ccd.c sys/dev/ida ida.c ida_disk.c sys/dev/md md.c sys/dev/mlx mlx.c sys/dev/vinum vinumdaemon.c vinumext.h vinuminterrupt.c vinumio.c vinumraid5.c vinumrequest.c vinumrevive.c vinumstate.c sys/dev/vn vn.c sys/gnu/ext2fs ext2_inode.c sys/i386/i386 genassym.c machdep.c vm_machdep.c sys/i386/isa labpc.c mcd.c scd.c wd.c wt.c sys/i386/isa/matcd matcd.c sys/isa fd.c sys/kern kern_physio.c subr_devstat.c subr_diskmbr.c subr_diskslice.c vfs_aio.c vfs_bio.c vfs_cluster.c vfs_default.c sys/miscfs/devfs devfs_vnops.c sys/miscfs/specfs spec_vnops.c sys/miscfs/union union_vnops.c sys/nfs nfs_bio.c nfs_syscalls.c nfs_vnops.c sys/ntfs ntfs_vnops.c sys/nwfs nwfs_io.c nwfs_vnops.c sys/pc98/i386 machdep.c sys/pc98/pc98 diskslice_machdep.c fd.c wd.c sys/sys buf.h conf.h sys/ufs/ffs ffs_inode.c sys/ufs/mfs mfs_vnops.c sys/ufs/ufs ufs_bmap.c ufs_disksubr.c sys/vm swap_pager.c vm_pager.c vm_swap.c vnode_pager.c Log: Remove B_READ, B_WRITE and B_FREEBUF and replace them with a new field in struct buf: b_iocmd. The b_iocmd is enforced to have exactly one bit set. B_WRITE was bogusly defined as zero giving rise to obvious coding mistakes. Also eliminate the redundant struct buf flag B_CALL, it can just as efficiently be done by comparing b_iodone to NULL. Should you get a panic or drop into the debugger, complaining about "b_iocmd", don't continue. It is likely to write on your disk where it should have been reading. This change is a step in the direction towards a stackable BIO capability. A lot of this patch were machine generated (Thanks to style(9) compliance!) Vinum users: Greg has not had time to test this yet, be careful. Revision Changes Path 1.69 +3 -3 src/sys/alpha/alpha/machdep.c 1.29 +2 -2 src/sys/alpha/alpha/vm_machdep.c 1.25 +7 -8 src/sys/cam/cam_periph.c 1.32 +2 -2 src/sys/cam/scsi/scsi_cd.c 1.44 +2 -2 src/sys/cam/scsi/scsi_da.c 1.18 +2 -2 src/sys/cam/scsi/scsi_pt.c 1.47 +6 -6 src/sys/cam/scsi/scsi_sa.c 1.24 +2 -2 src/sys/cam/scsi/scsi_target.c 1.17 +3 -3 src/sys/contrib/dev/fla/fla.c 1.58 +2 -2 src/sys/contrib/softupdates/ffs_softdep.c 1.8 +2 -2 src/sys/dev/amr/amr.c 1.64 +2 -2 src/sys/dev/ata/ata-disk.c 1.51 +5 -6 src/sys/dev/ata/atapi-cd.c 1.47 +4 -4 src/sys/dev/ata/atapi-fd.c 1.40 +5 -5 src/sys/dev/ata/atapi-tape.c 1.74 +12 -10 src/sys/dev/ccd/ccd.c 1.8 +2 -2 src/sys/dev/ida/ida.c 1.13 +2 -2 src/sys/dev/ida/ida_disk.c 1.9 +7 -7 src/sys/dev/md/md.c 1.16 +2 -2 src/sys/dev/mlx/mlx.c 1.17 +2 -2 src/sys/dev/vinum/vinumdaemon.c 1.26 +3 -3 src/sys/dev/vinum/vinumext.h 1.26 +11 -13 src/sys/dev/vinum/vinuminterrupt.c 1.53 +4 -3 src/sys/dev/vinum/vinumio.c 1.7 +5 -5 src/sys/dev/vinum/vinumraid5.c 1.45 +14 -14 src/sys/dev/vinum/vinumrequest.c 1.23 +10 -8 src/sys/dev/vinum/vinumrevive.c 1.29 +2 -2 src/sys/dev/vinum/vinumstate.c 1.106 +8 -8 src/sys/dev/vn/vn.c 1.25 +3 -1 src/sys/gnu/ext2fs/ext2_inode.c 1.87 +1 -2 src/sys/i386/i386/genassym.c 1.386 +3 -3 src/sys/i386/i386/machdep.c 1.133 +2 -2 src/sys/i386/i386/vm_machdep.c 1.36 +3 -3 src/sys/i386/isa/labpc.c 1.116 +2 -2 src/sys/i386/isa/mcd.c 1.55 +2 -2 src/sys/i386/isa/scd.c 1.220 +12 -12 src/sys/i386/isa/wd.c 1.59 +5 -4 src/sys/i386/isa/wt.c 1.50 +2 -2 src/sys/i386/isa/matcd/matcd.c 1.178 +7 -7 src/sys/isa/fd.c 1.47 +5 -5 src/sys/kern/kern_physio.c 1.18 +3 -3 src/sys/kern/subr_devstat.c 1.46 +3 -3 src/sys/kern/subr_diskmbr.c 1.83 +6 -8 src/sys/kern/subr_diskslice.c 1.71 +4 -5 src/sys/kern/vfs_aio.c 1.244 +34 -24 src/sys/kern/vfs_bio.c 1.93 +19 -13 src/sys/kern/vfs_cluster.c 1.29 +5 -5 src/sys/kern/vfs_default.c 1.92 +4 -4 src/sys/miscfs/devfs/devfs_vnops.c 1.133 +5 -5 src/sys/miscfs/specfs/spec_vnops.c 1.73 +2 -2 src/sys/miscfs/union/union_vnops.c 1.84 +14 -12 src/sys/nfs/nfs_bio.c 1.59 +2 -2 src/sys/nfs/nfs_syscalls.c 1.151 +5 -4 src/sys/nfs/nfs_vnops.c 1.10 +2 -2 src/sys/ntfs/ntfs_vnops.c 1.7 +2 -2 src/sys/nwfs/nwfs_io.c 1.7 +2 -2 src/sys/nwfs/nwfs_vnops.c 1.153 +3 -3 src/sys/pc98/i386/machdep.c 1.32 +3 -3 src/sys/pc98/pc98/diskslice_machdep.c 1.85 +7 -7 src/sys/pc98/pc98/fd.c 1.106 +12 -12 src/sys/pc98/pc98/wd.c 1.89 +8 -6 src/sys/sys/buf.h 1.104 +8 -2 src/sys/sys/conf.h 1.57 +2 -2 src/sys/ufs/ffs/ffs_inode.c 1.48 +11 -10 src/sys/ufs/mfs/mfs_vnops.c 1.36 +2 -2 src/sys/ufs/ufs/ufs_bmap.c 1.45 +7 -7 src/sys/ufs/ufs/ufs_disksubr.c 1.132 +13 -14 src/sys/vm/swap_pager.c 1.55 +4 -3 src/sys/vm/vm_pager.c 1.97 +2 -2 src/sys/vm/vm_swap.c 1.117 +3 -3 src/sys/vm/vnode_pager.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200003201044.CAA45049>