From owner-freebsd-threads@FreeBSD.ORG Thu Nov 27 04:21:28 2014 Return-Path: Delivered-To: freebsd-threads@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17D5D80B; Thu, 27 Nov 2014 04:21:28 +0000 (UTC) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.233.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AAC805F7; Thu, 27 Nov 2014 04:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=three; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=10ZQOghPJtFrx5lzqCXAVpOEp0F7V/ooQS0yUJg1SH8=; b=gn0Doh6wvqYJw2GB6tURMB9WU0oClcCl9v9gQxopnExiz97MJ3hJTZPd3+wlFW9VGiDlMec8uVduQLwUAq30ig3K4c0gnvwi4QQMt9Vjnqb4i6FQbFQl1NOqrNYXLTXjEG21uouvm7bFz0+iK5I/IMCrtMb6NxrSkFjcgyotDWrUpM+JPfMiwrsgtjocC/u8hQs1tlnTvpvmoMsiu13MkZBRatn3lQt6zQOQ9VJL7sKPheLnOnHqu3SalKH9isjiY2Mx5SDZ3D/6w0b05w3fU0Nm8bwN7wqjvKDJ9YfwGbdUmZqNHAxlxQrAhdg7ckrQK5ybKnhneMzwGnMGYEXWy1xYM35ONOklj1+mqToarowRrfy8KPiSu/r4IFzCv7PRk0sil/lYUBmlgK0FuQR6vJDDbSgUz0GS3GNrmHGy0KAPdkNcIUoKb26L/cZjKPyuvzPDTernCqG5sWBkc8bUMvWH1Xok67Z1WkEDm5QA7CtIcPxfk2YLUmgNpwLxYSku5EMKKoq+a5uSCXmSQxk9yaLrX6Rsvrh3tsVaAuU5xLTGVFAa+zOZ7RqBkYjDxZz2EGyIv3qpA7mO4d9WIkf2/09gXgRoNTB/q6hH1k8fY7mnt4UxFBUv80VEpuGpgtNIj29L7ESSNQcql8dRq5q7k7oFRiBYJN7/8ZsZMMpa/pg=; Received: from light.codelabs.ru (v-light.codelabs.ru [144.206.233.83]) by 0.mx.codelabs.ru with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) id 1XtqZy-000IHE-QT; Thu, 27 Nov 2014 08:21:19 +0400 Date: Thu, 27 Nov 2014 07:21:14 +0300 From: Eygene Ryabinkin To: Konstantin Belousov Subject: Re: [CFR][PATCH] Call proper signal handler from libthr for non-SA_SIGINFO case Message-ID: References: <20141120194925.GK17068@kib.kiev.ua> <20141121165658.GP17068@kib.kiev.ua> <20141121203227.GS17068@kib.kiev.ua> <20141126221734.GM17068@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5I6of5zJg18YgZEa" Content-Disposition: inline In-Reply-To: <20141126221734.GM17068@kib.kiev.ua> Sender: rea@codelabs.ru Cc: davidxu@FreeBSD.org, freebsd-threads@FreeBSD.org X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 04:21:28 -0000 --5I6of5zJg18YgZEa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thu, Nov 27, 2014 at 12:17:35AM +0200, Konstantin Belousov wrote: > On Thu, Nov 27, 2014 at 01:12:31AM +0300, Eygene Ryabinkin wrote: > >=20 > > Added them too. New patch is at > > http://codelabs.ru/fbsd/patches/libthr/11-CURRENT-fix-SIGINFO-process= ing-with-RESETHAND-v3.diff > >=20 >=20 > You went silent for several days, I committed the modified patch > earlier as r275120. >=20 > Thank you. Fine, thanks a lot! "td->td_ru.ru_nsignals++;" perhaps doesn't belong to the new function, but it is a matter of taste. By the way, shouldn't "PROC_LOCK_ASSERT(td->td_proc, MA_OWNED);" be also present single kern_sigprocmask() is called with SIGPROCMASK_PROC_LOCKED? --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --5I6of5zJg18YgZEa Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iL4EABEKAGYFAlR2prpfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDgyRkUwNkJDRDQ5N0MwREU0OUVDNEZGMDE2 QUY5RUFFODE1MkVDRkIACgkQFq+eroFS7PuvnAD+JCDxuJAOy4rdPwYJaUMBMnGL MlbJrJSFUIH1MgEaKKMA/iBw7JFiLvBtJ1jO14Y4quMy6j6ehRIyXVjVziA4+hVv =Hyos -----END PGP SIGNATURE----- --5I6of5zJg18YgZEa--