Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jul 1999 17:00:23 -0400 (EDT)
From:      Alfred Perlstein <bright@rush.net>
To:        Nate Williams <nate@mt.sri.com>
Cc:        "Brian F. Feldman" <green@FreeBSD.ORG>, hackers@FreeBSD.ORG, freebsd-ipfw@FreeBSD.ORG
Subject:   Re: securelevel and ipfw zero
Message-ID:  <Pine.BSF.3.96.990728164752.20420J-100000@cygnus.rush.net>
In-Reply-To: <199907282042.OAA03370@mt.sri.com>

Next in thread | Previous in thread | Raw E-Mail | Index | Archive | Help
On Wed, 28 Jul 1999, Nate Williams wrote:

> > > > > > These were changes that were necessary to make ipfw readable enough that
> > > > > > I could work with it in this area. They aren't just to clean it up, or
> > > > > > just for change's sake. They need to stay in.
> > > > > 
> > > > > C'mon now, re-ording the lines is *certainly* not necessary to work.
> > > > 
> > > > That's true. I sure didn't do that.
> > > 
> > > Sure looks like you did.  There are white-space and re-ordering
> > > modifications in the diffs you sent out.  If you didn't do them, who
> > > did?
> > 
> > I refuse to justify putting variables in a function I changed in the
> > right place.
> 
> This and other obnoxious responses to valid responses makes me want to
> ask for your commit privileges.  You obviously don't care what anyone
> else has done.
> 
> > > In particular, the changes I pointed out are not 'cleanups', but style
> > > changes.
> > 
> > When you make code readable, it's a cleanup.
> 
> The code is *NO* more readable by you re-ordering lines and changes
> whitespace.

This is so very objective.

> 
> Grow up and quit acting like a child who doesn't wanna follow the rules.

quit acting like and old fart that fears change. (*)

afaik, Brian is the mainter of ipfw, it should be noted so, so that
if his changes break something it comes down on his head.  Trust
me to say something if that occurs.  

I'm no big friend of Brian, however changes to correct readability 
should be welcome especially to the maintainer.

-Alfred Perlstein - [bright@rush.net|bright@wintelcom.net] 
systems administrator and programmer
    Wintelcom - http://www.wintelcom.net/

(*) if you don't like "old fart" then choose to play the age card
with a bit more thought, there are many other commiters that fall
under your catagorization.





To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ipfw" in the body of the message




Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.990728164752.20420J-100000>