From owner-svn-ports-head@freebsd.org  Thu Apr 13 14:06:44 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 81943D3C497;
 Thu, 13 Apr 2017 14:06:44 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Received: from critical.ch (critical.ch [IPv6:2a01:4f8:c17:de4::1:1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "critical.ch", Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2962FB0;
 Thu, 13 Apr 2017 14:06:44 +0000 (UTC)
 (envelope-from ehaupt@FreeBSD.org)
Received: from wiggles.local (dynamic.wline.6rd.res.cust.swisscom.ch
 [IPv6:2a02:120b:2c62:8260:dad3:85ff:fe79:dd2] (may be forged))
 (authenticated bits=0)
 by critical.ch (8.15.2/8.15.2/critical-1.0) with ESMTPA id v3DE6XWe028585;
 Thu, 13 Apr 2017 16:06:39 +0200 (CEST)
 (envelope-from ehaupt@FreeBSD.org)
Date: Thu, 13 Apr 2017 16:06:28 +0200
From: Emanuel Haupt <ehaupt@FreeBSD.org>
To: Dmitry Marakasov <amdmi3@amdmi3.ru>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r438383 - in head/audio: . schism schismtracker
Message-Id: <20170413160628.b1fff75fc5513333eb42b33a@FreeBSD.org>
In-Reply-To: <20170413092634.GB47519@hades.panopticon>
References: <201704121630.v3CGUZ7f023880@repo.freebsd.org>
 <20170412173502.GA88685@hades.panopticon>
 <f1c63624-3bcd-76e1-c89b-d7bed0d4725f@FreeBSD.org>
 <20170413092634.GB47519@hades.panopticon>
X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; amd64-portbld-freebsd11.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Apr 2017 14:06:44 -0000

Dmitry Marakasov <amdmi3@amdmi3.ru> wrote:
> * Emanuel Haupt (ehaupt@FreeBSD.org) wrote:
> 
> > >> Author: ehaupt
> > >> Date: Wed Apr 12 16:30:34 2017
> > >> New Revision: 438383
> > >> URL: https://svnweb.freebsd.org/changeset/ports/438383
> > >>
> > >> Log:
> > >>   - Rename audio/schism for better naming
> > >>   - Add .desktop files for tracker and editor
> > >>   - Provide icons
> > >
> > > Nice! But it's missing MOVED entry. Also WWW should be updated to
> > > http://schismtracker.org/
> > 
> > See r438384. I've deliberately committed it (less than 10 seconds
> > later) separately  because this commit log contains information
> > that does not concern ports/MOVED (icons/dekstop).
> 
> There's no reason why commits to MOVED must not include other changes.
> Separating actual move and MOVED change is a bad approach IMO.

The reason why I prefer it separate is that ports/MOVED and the actual
port change is in a different section of the tree. If it is committed
together and someone is looking at the svn log of ports/MOVED he's
going to see all the unrelated rest (Add .desktop files...). I like it
that way, you like it the other way. Neither is "bad" it's just a
different style.