Date: Sun, 9 Aug 2015 09:37:13 +0200 From: Ed Schouten <ed@nuxi.nl> To: Alexander Kabaev <kabaev@gmail.com> Cc: Ed Schouten <ed@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285910 - in head: lib/libc/sys sys/kern sys/sys Message-ID: <CABh_MK=PjDUh73aPEX5yTdkgCJ--3NwKV7ZS6KvP5GYfOU1aYw@mail.gmail.com> In-Reply-To: <20150808150539.0b43cfcd@kan> References: <201507271317.t6RDHwpj067194@repo.freebsd.org> <20150808150539.0b43cfcd@kan>
next in thread | previous in thread | raw e-mail | index | archive | help
--001a113cae68fbad7c051cdbef59 Content-Type: text/plain; charset=UTF-8 Hi Alexander, 2015-08-08 21:05 GMT+02:00 Alexander Kabaev <kabaev@gmail.com>: > this commit broke more than just syslogd. rtsol and rtsold both are > victims of the change as they are trying to shutdown unconnected > raw sockets to make then 'send-only' and fail. Good catch! I think that in this case it is safe to omit the call to shutdown(), or at least not let the application fail on startup because of shutdown() being more strict. After all, this code would fail on Linux, OS X, etc. already because of this. Could you test the attached patch and let me know whether it makes rtsol/rtsold work again? Thanks, -- Ed Schouten <ed@nuxi.nl> Nuxi, 's-Hertogenbosch, the Netherlands KvK/VAT number: 62051717 --001a113cae68fbad7c051cdbef59 Content-Type: text/plain; charset=US-ASCII; name="rtsold.diff" Content-Disposition: attachment; filename="rtsold.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_id46gcon1 ZGlmZiAtLWdpdCBhL3Vzci5zYmluL3J0c29sZC9wcm9iZS5jIGIvdXNyLnNiaW4vcnRzb2xkL3By b2JlLmMKaW5kZXggODlhMTYxN2EuLjNhYTUzMDMgMTAwNjQ0Ci0tLSBhL3Vzci5zYmluL3J0c29s ZC9wcm9iZS5jCisrKyBiL3Vzci5zYmluL3J0c29sZC9wcm9iZS5jCkBAIC04MCwxMiArODAsNiBA QCBwcm9iZV9pbml0KHZvaWQpCiAJCXJldHVybiAoLTEpOwogCX0KIAotCS8qIG1ha2UgdGhlIHNv Y2tldCBzZW5kLW9ubHkgKi8KLQlpZiAoc2h1dGRvd24ocHJvYmVzb2NrLCAwKSkgewotCQl3YXJu bXNnKExPR19FUlIsIF9fZnVuY19fLCAic2h1dGRvd246ICVzIiwgc3RyZXJyb3IoZXJybm8pKTsK LQkJcmV0dXJuICgtMSk7Ci0JfQotCiAJLyogaW5pdGlhbGl6ZSBtc2doZHIgZm9yIHNlbmRpbmcg cGFja2V0cyAqLwogCXNuZG1oZHIubXNnX25hbWVsZW4gPSBzaXplb2Yoc3RydWN0IHNvY2thZGRy X2luNik7CiAJc25kbWhkci5tc2dfaW92ID0gc25kaW92Owo= --001a113cae68fbad7c051cdbef59--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MK=PjDUh73aPEX5yTdkgCJ--3NwKV7ZS6KvP5GYfOU1aYw>