Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Oct 2003 00:21:34 +0100 (CET)
From:      Lars Thegler <lars@thegler.dk>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/58585: [MAINTAINER] audio/daapd: Improved logfile placement
Message-ID:  <20031026232134.2AF443EB3@dask.thegler.dk>
Resent-Message-ID: <200310262330.h9QNUJUA077232@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         58585
>Category:       ports
>Synopsis:       [MAINTAINER] audio/daapd: Improved logfile placement
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 26 15:30:18 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Lars Thegler
>Release:        FreeBSD 4.9-RC i386
>Organization:
>Environment:
System: FreeBSD dask.thegler.dk 4.9-RC FreeBSD 4.9-RC #0: Sat Oct  4 18:34:10 CEST
>Description:
- Now logs to /var/log/ instead of application specific location.
- Bumped PORTREVISION, but I'm not sure whether that's needed here.

Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:

--- daapd-0.2.1c_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/daapd/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile
--- Makefile	23 Oct 2003 20:24:42 -0000	1.1
+++ Makefile	26 Oct 2003 23:19:42 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	daapd
 PORTVERSION=	0.2.1c
+PORTREVISION=	1
 CATEGORIES=	audio
 MASTER_SITES=	http://www.deleet.de/projekte/daap/daapd/
 EXTRACT_SUFX=	.tgz
@@ -30,7 +31,7 @@
 DAAPD_USER=	daapd
 DAAPD_GROUP=	daapd
 
-LOGDIR=		${DATADIR}
+LOGDIR=		/var/log
 FILES_SUB=	USER=${DAAPD_USER} GROUP=${DAAPD_GROUP} \
 		PREFIX=${PREFIX} LOGDIR=${LOGDIR} DOCSDIR=${DOCSDIR} \
 		LOCALBASE=${LOCALBASE}
Index: pkg-install
===================================================================
RCS file: /home/ncvs/ports/audio/daapd/pkg-install,v
retrieving revision 1.1
diff -u -r1.1 pkg-install
--- pkg-install	23 Oct 2003 20:24:42 -0000	1.1
+++ pkg-install	26 Oct 2003 23:19:42 -0000
@@ -23,17 +23,8 @@
   else
     echo "---> Adding user \"%%USER%%\""
     pw adduser %%USER%% -g %%GROUP%% -h - \
-      -d "%%LOGDIR%%" -s "/sbin/nologin" -c "daapd User" || exit 1
+      -d "/nonexistent" -s "/sbin/nologin" -c "daapd User" || exit 1
   fi
-
-  ;;
-
-POST-INSTALL)
-  echo "---> Starting post-install script:"
-
-  echo "---> Creating directory \"%%LOGDIR%%\""
-  mkdir %%LOGDIR%%
-  chown %%USER%% %%LOGDIR%%
 
   ;;
 
Index: files/daapd.sh
===================================================================
RCS file: /home/ncvs/ports/audio/daapd/files/daapd.sh,v
retrieving revision 1.1
diff -u -r1.1 daapd.sh
--- files/daapd.sh	23 Oct 2003 20:24:42 -0000	1.1
+++ files/daapd.sh	26 Oct 2003 23:19:42 -0000
@@ -10,8 +10,7 @@
 case "$1" in
 	start)
 		if [ -r "${DAAPD_CONF}" ]; then
-			su -m ${DAAPD_USER} -c "${DAAPD} -c ${DAAPD_CONF}" \
-				>> ${DAAPD_LOG} 2>&1 &
+			su -m ${DAAPD_USER} -c "${DAAPD} -c ${DAAPD_CONF}" >> ${DAAPD_LOG} 2>&1 &
 			echo $(($!+1)) > "${DAAPD_PID}"
 			echo -n ' daapd'
 		fi
--- daapd-0.2.1c_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031026232134.2AF443EB3>