From owner-freebsd-current@FreeBSD.ORG Thu May 28 22:33:52 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DA8C7469; Thu, 28 May 2015 22:33:52 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 90D30CD2; Thu, 28 May 2015 22:33:52 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::9dd2:9f27:c86f:473e] (unknown [IPv6:2001:7b8:3a7:0:9dd2:9f27:c86f:473e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id B18892739E; Fri, 29 May 2015 00:33:40 +0200 (CEST) Subject: Re: Need help reducing compilation warnings in CURRENT Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: multipart/signed; boundary="Apple-Mail=_122A08D4-7846-4B54-AD3B-9440A864F4A0"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: Date: Fri, 29 May 2015 00:33:31 +0200 Cc: Johannes Jost Meixner , freebsd-current Current , "freebsd-testing@freebsd.org" Message-Id: References: <55670C5A.6080500@FreeBSD.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.2098) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 22:33:53 -0000 --Apple-Mail=_122A08D4-7846-4B54-AD3B-9440A864F4A0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 28 May 2015, at 21:09, Craig Rodrigues wrote: > > On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner ... >> The warnings are almost all in contrib/ areas. Hence, any fix might >> want to probably be submitted to upstream first. >> > Sure, if we can push fixes upstream that would be great. > However, we shouldn't let that block us from comitting fixes to FreeBSD. Yes, that should block us in most cases, since it will make future merges more difficult. We should only fix these types of warnings locally, if: 1) The contrib project's upstream is dead, unresponsive, or hostile. 2) You are sure that you don't introduce new bugs by modifying stuff. (You definitely don't want to repeat e.g. Debian's OpenSSL fiasco.) 3) You are sure that the warning exposes a real bug, that cannot be worked around in some other way. 4) You are sure that you want to take the maintenance burden of future merges. > The advantage of having code in the FreeBSD repo is that we can > change it if we need to, even if the fix isn't yet in the upstream sources. > Contrib code is not made out of stone that can't be modified! Certainly not, but unless you have very good reasons to modify upstream code locally, you should not bother. Better spend your energy to file fixes upstream, and let *them* verify that they are correct. -Dimitry --Apple-Mail=_122A08D4-7846-4B54-AD3B-9440A864F4A0 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlVnl8QACgkQsF6jCi4glqMv1QCglnhQ84EEfCBtWHltsahsApky 9lwAoLNsJfNJ+szQJdSxkaTAxT4JUqos =476i -----END PGP SIGNATURE----- --Apple-Mail=_122A08D4-7846-4B54-AD3B-9440A864F4A0--