From owner-svn-ports-head@freebsd.org Fri Oct 7 06:33:57 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09C82BEC742; Fri, 7 Oct 2016 06:33:57 +0000 (UTC) (envelope-from brnrd@FreeBSD.org) Received: from smtp02.qsp.nl (smtp02.qsp.nl [193.254.214.163]) by mx1.freebsd.org (Postfix) with ESMTP id BDFE61E4; Fri, 7 Oct 2016 06:33:56 +0000 (UTC) (envelope-from brnrd@FreeBSD.org) Received: from smtp02.qsp.nl (localhost [127.0.0.1]) by smtp02.qsp.nl (Postfix) with ESMTP id A8AECFD0AE; Fri, 7 Oct 2016 08:27:10 +0200 (CEST) Received: from mail.brnrd.eu (unknown [193.164.217.85]) by smtp02.qsp.nl (Postfix) with ESMTP; Fri, 7 Oct 2016 08:27:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=brnrd.eu; h=date:from:to:subject:message-id; s=default; bh=DV6Jghsn7bpj3zSxq3D6tGQFwOVl+MuYcv/+wfNbYVE=; b=gsIvnsPilvxz/7iX9xCNfeobAW8N2XsbZNTpCIT2EDoQV9VpuCfo4I1/omG4MmUOMpKBPgl1yuGeuxIQy1Q4VJjUpxvj+W538FpPg2AAjIjElXcgcTeaJG/6hb8imJ9MIDkVMI1LjA7oE68jxIDFfl4ryR1+hcK1KmqLbFnkz2fkiK2HEQYxJZNAQRuxLQqi3LKw5dNV2fhIXR+UV4P2yh3/DNalF7/zrjFwP2OuX+ddbAhlmmWdGmKkmjGMni1ZxcJcf5H/+Bl1juMJDwwp6o/GverZeyN0ml1n/S4nLgA6BG39qk8PKBi0n9et8eBJg9vMbMFYU1dCAK15CBdE2Q== Received: by bachfreund.nl (OpenSMTPD) with ESMTPSA id 99def46e TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Fri, 7 Oct 2016 08:27:09 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 07 Oct 2016 08:27:09 +0200 From: Bernard Spil To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r423434 - head/security/openssl In-Reply-To: References: <201610061938.u96JcmrW038201@repo.freebsd.org> Message-ID: X-Sender: brnrd@FreeBSD.org User-Agent: Roundcube Webmail/1.2.2 X-Virus-Scanned: clamav at smtp02 X-Spam-Status: No, score=1.6 required=5.0 tests=HK_RANDOM_ENVFROM, HK_RANDOM_FROM,UNPARSEABLE_RELAY autolearn=disabled version=3.4.1 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on svfilter01.qsp.nl X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 06:33:57 -0000 On 2016-10-07 0:44, Mathieu Arnold wrote: > Le 06/10/2016 à 21:38, Bernard Spil a écrit : >> Author: brnrd >> Date: Thu Oct 6 19:38:48 2016 >> New Revision: 423434 >> URL: https://svnweb.freebsd.org/changeset/ports/423434 >> >> Log: >> security/openssl: Fix ldconfig issue >> >> - OPT_USE= feature does not behave as expected > > I strongly disagree with that comment, the opt_USE works exactly as > expected, and as documented. > >> Reported by: dinoex >> Differential Revision: D8166 >> >> Modified: >> head/security/openssl/Makefile >> >> Modified: head/security/openssl/Makefile >> ============================================================================== >> --- head/security/openssl/Makefile Thu Oct 6 19:35:40 2016 (r423433) >> +++ head/security/openssl/Makefile Thu Oct 6 19:38:48 2016 (r423434) >> @@ -88,7 +88,7 @@ SCTP_CONFIGURE_OFF= no-sctp >> SHARED_CONFIGURE_ON= shared >> SHARED_MAKE_ENV= SHLIBVER=${OPENSSL_SHLIBVER} >> SHARED_PLIST_SUB= SHLIBVER=${OPENSSL_SHLIBVER} >> -SHARED_USE= ldconfig >> +SHARED_USE= ldconfig=yes >> SSE2_CONFIGURE_OFF= no-sse2 >> SSL2_CONFIGURE_ON= enable-ssl2 >> SSL2_CONFIGURE_OFF= no-ssl2 >> >> Hi Mat, From Mk/bsd.options.mk: 499: _u= ${option:C/=.*//g} 500: USE_${_u:tu}+= ${option:C/.*=//g:C/,/ /g} If you forget to add =value to your OPT_USE= feature this will result in USE_FEATURE= feature as there's no `=' to split on. This should either default to something sane (i.e. "yes") or throw an error. Cheers, Bernard.