Date: Wed, 1 Apr 2015 11:41:28 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Ryan Steinmetz <zi@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r382905 - in head/sysutils: qjail qjail2 Message-ID: <20150401114128.GB82458@FreeBSD.org> In-Reply-To: <201504011135.t31BZqWp028637@svn.freebsd.org> References: <201504011135.t31BZqWp028637@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 01, 2015 at 11:35:52AM +0000, Ryan Steinmetz wrote: > New Revision: 382905 > URL: https://svnweb.freebsd.org/changeset/ports/382905 > > [...] > @${MKDIR} ${STAGEDIR}${EXAMPLESDIR} > - @(cd ${WRKSRC}/examples/ \ > + (cd ${WRKSRC}/examples/ \ > && ${COPYTREE_SHARE} \* ${STAGEDIR}${EXAMPLESDIR}) Using dot (.) instead of \* is shorter, more readable, and less error-prone (no need to think about escaping). That's why it is recommended by the PHB. Since you've touched that command, you might have considered fixing this as well. > @${MKDIR} ${STAGEDIR}${EXAMPLESDIR} > - @(cd ${WRKSRC}/examples/ \ > + (cd ${WRKSRC}/examples/ \ > && ${COPYTREE_SHARE} \* ${STAGEDIR}${EXAMPLESDIR}) Ditto. Also, notice bogus indentation of the backslash. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150401114128.GB82458>