From owner-freebsd-net@FreeBSD.ORG Sat Nov 26 00:53:45 2005 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0CE8616A423 for ; Sat, 26 Nov 2005 00:53:45 +0000 (GMT) (envelope-from danallen46@airwired.net) Received: from mail.digitalworx.net (mail.digitalworx.net [209.90.82.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 27D9443D90 for ; Sat, 26 Nov 2005 00:53:23 +0000 (GMT) (envelope-from danallen46@airwired.net) Received: (qmail 15083 invoked by uid 508); 26 Nov 2005 00:53:14 -0000 Received: from unknown (HELO ?192.168.0.24?) (danallen46@airwired.net@216.83.138.247) by 0 with SMTP; 26 Nov 2005 00:53:14 -0000 Mime-Version: 1.0 (Apple Message framework v746.2) Content-Transfer-Encoding: 7bit Message-Id: <1389F11F-787F-40BE-AEEA-6352F530BE61@airwired.net> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed To: freebsd-net@freebsd.org From: Dan Allen Date: Fri, 25 Nov 2005 17:53:12 -0700 X-Mailer: Apple Mail (2.746.2) Subject: cvs commit: src/sys/netinet if_ether.c X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Nov 2005 00:53:45 -0000 The following change appears to have crashed my network today. If I back up to the revision of src/sys/netinet/if_ether.c prior to this, my machine is fine, but otherwise it will not talk to my Netgear router's DHCP server properly and in fact it almost does a Denial of Service on the router! Every light on the router is on - the machine hangs at boot waiting for a DHCP address, and then it hangs again when sshd starts up. I am not a network guru (more of a compiler guy) but I think this change should be investigated or possibly backed out. If there are questions, feel free to email me. Dan Allen Building FreeBSD since 2.0... --- Commit by glebius on RELENG_6 :: src/sys/netinet/if_ether.c: MFC 1.145: Rework ARP retransmission algorythm so that ARP requests are retransmitted without suppression, while there is demand for such ARP entry. As before, retransmission is rate limited to one packet per second. Details: Remove net.link.ether.inet.host_down_time Do not set/clear RTF_REJECT flag on route, to avoid rt_check() returning error. We will generate error ourselves. Return EWOULDBLOCK on first arp_maxtries failed requests , and return EHOSTDOWN/EHOSTUNREACH on further requests. Retransmit ARP request always, independently from return code. Ratelimit to 1 pps.