Date: Thu, 14 Jun 2018 22:49:41 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Eitan Adler <eadler@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Bruce Evans <brde@optusnet.com.au>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r333945 - head/usr.bin/top Message-ID: <20180614223558.S2349@besplex.bde.org> In-Reply-To: <CAF6rxgkPZukK30c-eGWu3566ytTz7WUaVKSceog9tLs%2BAuEg8A@mail.gmail.com> References: <201805202319.w4KNJ9hj038452@repo.freebsd.org> <20180521094344.Q1053@besplex.bde.org> <20180521063953.GA70671@FreeBSD.org> <20180610122819.GA75055@FreeBSD.org> <CAF6rxgnvrsPRvL1dqFu6Pb6p8sszbzXEOaU6YHKZ5FCSn8g9hw@mail.gmail.com> <20180610162653.GA2999@FreeBSD.org> <CAF6rxgkPZukK30c-eGWu3566ytTz7WUaVKSceog9tLs%2BAuEg8A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 14 Jun 2018, Eitan Adler wrote: > On 10 June 2018 at 09:26, Alexey Dokuchaev <danfe@freebsd.org> wrote: >> On Sun, Jun 10, 2018 at 08:56:24AM -0700, Eitan Adler wrote: >>> On 10 June 2018 at 05:28, Alexey Dokuchaev <danfe@freebsd.org> wrote: >>>> I've just tried the latest top(1). Now it's even worse: >>>> ... >>>> Also, it is COMMA now. Can we please do something about this? I am not >>>> calling for "USER PRI" as Bruce had suggested, but "USERNAME PRI" is just >>>> about right. >>> >>> FWIW I have not forgotten about this. I am planning on completely >>> rewriting how the header, and data, get displayed so its low my >>> priority (pun intended) list to fix this specific case until then. >> >> Great! Looking forward to improvements. top(1) should be neat(TM). >> Take your time Eitan, it's not that urgent. > > What do y'all think of https://reviews.freebsd.org/D15801 ? It changes > the username length to 8 unconditionally. Its rolled into a rewrite of > how the header gets created in order to actually make it > understandable. Hard-coded 8 is too simple. Old versions were easy enough to understand, but that depends on them mostly being hard-coded. I don't like to review anything that is not in mail. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180614223558.S2349>