Date: Tue, 31 Dec 2019 13:17:53 +0100 From: Torsten Zuehlsdorff <freebsd@toco-domains.de> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r521584 - head/Mk Message-ID: <837eebf0-4d04-53cf-0fec-225b9dd5125c@toco-domains.de> In-Reply-To: <alpine.LSU.2.21.1912311853470.13725@anthias.pfeifer.com> References: <201912310306.xBV36oQM081788@repo.freebsd.org> <5eadceb4-790d-21c3-e5db-cd5a27d8e5f4@toco-domains.de> <alpine.LSU.2.21.1912311853470.13725@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31.12.19 09:58, Gerald Pfeifer wrote: > On Tue, 31 Dec 2019, Torsten Zuehlsdorff wrote: >>> -# USE_GCC= 7+ # port requires GCC 7 or later. >>> -# USE_GCC= 6 # port requires GCC 6. >> You remove the USE_GCC= 7+ comment here, while 7 is still used later. Is >> this intended? > > The idea was not to remove that example altogether, but update it > to use a newer version. > > A simplified version of the commit looks as follows: > > -# USE_GCC= 7+ # port requires GCC 7 or later. > +# USE_GCC= 9+ # port requires GCC 9 or later. > > The other example that referred to GCC 6 was mandatory to update since > USE_GCC=6 is not supported any more; version 7 I could have left in, but > figured pointing people to something newer would be better. > > In general the USE_GCC=X+ is mostly used for ports newer than the current > default. Just with GCC_DEFAULT at 9, which is the newest release available, > that was the highest choice available - until GCC 10 becomes available in > spring. ;-) > > Would you prefer different examples in Mk/bsd.gcc.mk? Thank you for your explanation Gerald. With this insight your diff looks fine and i do not think a different example is needed. :) Greetings, Torsten
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?837eebf0-4d04-53cf-0fec-225b9dd5125c>