Date: Tue, 03 Sep 2019 14:07:15 -0000 From: John Baldwin <jhb@FreeBSD.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: Enji Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r346449 - user/ngie/bug-237403/tests/sys/opencrypto Message-ID: <876fef44-1b27-75e3-211c-8d8682b9f59b@FreeBSD.org> In-Reply-To: <153E9E58-3071-46FF-9A8E-61AE7FED49FA@gmail.com> References: <201904201607.x3KG7m4A051487@repo.freebsd.org> <23c35177-f384-7f1f-3e4a-f8badcfac560@FreeBSD.org> <153E9E58-3071-46FF-9A8E-61AE7FED49FA@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/20/19 9:29 AM, Enji Cooper wrote: > >> On Apr 20, 2019, at 9:28 AM, John Baldwin <jhb@FreeBSD.org> wrote: >> >> On 4/20/19 9:07 AM, Enji Cooper wrote: >>> Author: ngie >>> Date: Sat Apr 20 16:07:47 2019 >>> New Revision: 346449 >>> URL: https://svnweb.freebsd.org/changeset/base/346449 >>> >>> Log: >>> Replace `str.{decode,encode}("hex")` with binascii.(un)?hexlify >>> >>> Encoding/decoding base_string objects as "hex" was removed in py3 and replaced >>> with other methods, one being `binascii.(un)?hexlify`. >> >> I have several changes pending in review for these scripts that add new functions, >> etc. You might want to let those land in head first. I hope to merge them all to >> head this week. > > Good to know! Is the code up for review somewhere, so I can get ahead of the pending changes? > Thanks so much for the heads up! You can look at D19778 and then look at its stack of dependencies. I'm waiting for the ports one to hit maintainer timeout which will then unblock the remaining changes. Getting these tests to work with both python 3 and 2 is a useful exercise and appreciated. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?876fef44-1b27-75e3-211c-8d8682b9f59b>