From owner-svn-ports-head@FreeBSD.ORG  Thu Oct  2 16:55:12 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D46209DA;
 Thu,  2 Oct 2014 16:55:12 +0000 (UTC)
Received: from mail-oi0-x229.google.com (mail-oi0-x229.google.com
 [IPv6:2607:f8b0:4003:c06::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7AD8DEFB;
 Thu,  2 Oct 2014 16:55:12 +0000 (UTC)
Received: by mail-oi0-f41.google.com with SMTP id u20so2248884oif.14
 for <multiple recipients>; Thu, 02 Oct 2014 09:55:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=bKcj+jxtFJczjzfWSB/zY5D26WBrrL0mxCacAvEa0wY=;
 b=Qi75keASgczdjHr4blQ2akhtLniiKXUR8jrE9Pk+nCJdeVRyY5OYXvao9em/J/6Csh
 zER13OXLCdCl9IzRoLDOeH9LdN4nmrKArSo2YpMFONWsLmYBKXZzefmjBVkS11k+4vcC
 q4e3wQGbpHoxQjSnvE4XNRBDSNxZqRYlqhg1SBmU0DmfQOlc074S17e9/e4IkbNr/xA0
 S72tqdKZb2nt7BwoBHeLzmoWOqthc3Fl4wQCPbyPMqqseIun2Ofgpvc70scvgFLgugb1
 R9PYtRV5QJd/QzVYi249Or9VX2gqXZ6XZ5rxe2VRwJ5fcfNpflVhdkO8FIPbYpWKJLDQ
 WO7Q==
MIME-Version: 1.0
X-Received: by 10.182.33.66 with SMTP id p2mr64156902obi.51.1412268911249;
 Thu, 02 Oct 2014 09:55:11 -0700 (PDT)
Sender: r.c.ladan@gmail.com
Received: by 10.182.19.133 with HTTP; Thu, 2 Oct 2014 09:55:11 -0700 (PDT)
Received: by 10.182.19.133 with HTTP; Thu, 2 Oct 2014 09:55:11 -0700 (PDT)
In-Reply-To: <201410021545.s92FjgmN047846@svn.freebsd.org>
References: <201410021545.s92FjgmN047846@svn.freebsd.org>
Date: Thu, 2 Oct 2014 18:55:11 +0200
X-Google-Sender-Auth: 82gCIGRnhWu6ziTvPUF78_SVCF0
Message-ID: <CADL2u4hT9r05MW9bJK4XNR0N07g9MfQcQ-RKPT+Ly5QnG_0q=A@mail.gmail.com>
Subject: Re: svn commit: r369832 - head/net/aoe
From: =?UTF-8?Q?Ren=C3=A9_Ladan?= <rene@freebsd.org>
To: Bapt <bapt@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Oct 2014 16:55:13 -0000

Op 2 okt. 2014 17:45 schreef "Baptiste Daroussin" <bapt@freebsd.org>:
>
> Author: bapt
> Date: Thu Oct  2 15:45:42 2014
> New Revision: 369832
> URL: https://svnweb.freebsd.org/changeset/ports/369832
> QAT: https://qat.redports.org/buildarchive/r369832/
>
> Log:
>   Make sure the package respect SRC_BASE
>   Use the kmod framework
>   Cleanup the plist
>
>   Reported by:  glebius
>
> Modified:
>   head/net/aoe/Makefile
>   head/net/aoe/pkg-plist
>
> Modified: head/net/aoe/Makefile
>
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/net/aoe/Makefile       Thu Oct  2 15:44:03 2014        (r369831)
> +++ head/net/aoe/Makefile       Thu Oct  2 15:45:42 2014        (r369832)
> @@ -3,6 +3,7 @@
>
>  PORTNAME=3D      aoe
>  PORTVERSION=3D   1.2.0
> +PORTREVISION=3D  1
>  CATEGORIES=3D    net kld

Kmod already adds the kld category.

>  MASTER_SITES=3D  http://www.son.org/download/
>  DISTNAME=3D      ${PORTNAME}-freebsd-${PORTVERSION}
> @@ -10,22 +11,17 @@ DISTNAME=3D   ${PORTNAME}-freebsd-${PORTVERS
>  MAINTAINER=3D    fjoe@FreeBSD.org
>  COMMENT=3D       FreeBSD driver for ATA over Ethernet (AoE)
>
> -NO_PACKAGE=3D    Should be in sync with the kernel to work correctly
>  SSP_UNSAFE=3D    kernel module does not support ssp
>
Kmod also sets SSP_UNSAFE

Regards,
Ren=C3=A9

> +USES=3D  kmod
> +
>  WRKSRC=3D                ${WRKDIR}/dev/aoe
> -USE_RC_SUBR=3D   aoe
> +KMODDIR=3D       ${PREFIX}/lib/aoe
>
> -pre-everything::
> -       @if [ ! -f /usr/src/sys/Makefile ]; then \
> -               ${ECHO_MSG} ">> The AoE port needs FreeBSD kernel source
code to compile."; \
> -               ${ECHO_MSG} ">> Please install FreeBSD kernel source code
in /usr/src/sys."; \
> -               ${FALSE}; \
> -       fi
> +USE_RC_SUBR=3D   aoe
>
>  do-install:
> -       ${MKDIR} ${STAGEDIR}${PREFIX}/lib/aoe
>         ${INSTALL_KLD} ${WRKSRC}/aoe.ko ${STAGEDIR}${PREFIX}/lib/aoe
> -       ${INSTALL_MAN} ${WRKDIR}/aoe.4 ${STAGEDIR}${PREFIX}/man/man4
> +       ${INSTALL_MAN} ${WRKDIR}/aoe.4 ${STAGEDIR}${PREFIX}/man/man4/
>
>  .include <bsd.port.mk>
>
> Modified: head/net/aoe/pkg-plist
>
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/net/aoe/pkg-plist      Thu Oct  2 15:44:03 2014        (r369831)
> +++ head/net/aoe/pkg-plist      Thu Oct  2 15:45:42 2014        (r369832)
> @@ -1,3 +1,2 @@
>  lib/aoe/aoe.ko
>  man/man4/aoe.4.gz
> -@dirrm lib/aoe
>