Date: Wed, 14 Aug 2013 08:17:44 -0700 From: Sean Bruno <sean_bruno@yahoo.com> To: Doug Ambrisko <ambrisko@ambrisko.com> Cc: "FreeBSD-scsi@freebsd.org" <FreeBSD-scsi@freebsd.org> Subject: Re: Dell H310, JBOD mode "hard error" Message-ID: <1376493464.1377.3.camel@localhost> In-Reply-To: <20130814150331.GB34825@ambrisko.com> References: <1373822621.1431.5.camel@localhost> <1376448416.1439.7.camel@localhost> <20130814150331.GB34825@ambrisko.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-0SZy4tGwEQjKTRv7VbEY Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > That change for d_maxsize looks okay but do you really want to get > rid of d_open? I assume this is a cut-n-paste type error and the patch > (hand editted) should be: >=20 > Index: mfi_syspd.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- mfi_syspd.c (revision 254313) > +++ mfi_syspd.c (working copy) > @@ -128,7 +128,8 @@ > sc->pd_disk->d_drv1 =3D sc; > - sc->pd_disk->d_maxsize =3D sc->pd_controller->mfi_max_io * secsize; > + sc->pd_disk->d_maxsize =3D min(sc->pd_controller->mfi_max_io * secsize, > + (sc->pd_controller->mfi_max_sge - 1) * PAGE_SIZE); > sc->pd_disk->d_name =3D "mfisyspd"; > sc->pd_disk->d_open =3D mfi_syspd_open; > sc->pd_disk->d_close =3D mfi_syspd_close; > sc->pd_disk->d_strategy =3D mfi_syspd_strategy; > sc->pd_disk->d_dump =3D mfi_syspd_dump; >=20 Bah, that's why I always send patches for review. Yes, the d_open deletion was a typo. Thanks for the update. > BTW, has mfiutil been updated to create real JBODs versus the RAID per > drive? I know someone was talking about doing that. A note on implement= ing > it, it also requires JBOD to be enabled in the controller. I'm not sure > if all controllers support it. I forget when I was playing with it. I'v= e > always wondering if we should change the name for the syspd disk node > but I left it for compatibility with LSI. We could do an alias. It is > good in away that it doesn't create /dev/mfid* nodes so that it is easier > to track bugs. mfiutil doesn't seem to know how to deal with SYSPD (real JBOD) at this time. It only allows you to see the physical drives, nothing shows up on the "show volumes" command. =46rom what I see the Dell H310 doing, there's not much there in the system to do with the real JBOD devices. I mean, there's no creation/deletion or other RAID things to do here. Sean --=-0SZy4tGwEQjKTRv7VbEY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (FreeBSD) iQEcBAABAgAGBQJSC5+QAAoJEBkJRdwI6BaHiPAH/0OpKcwAw/OBkg3OVSh4ZGWN p+GKqDrhCevhzgDCaVneMXz51rf1yDom2T72qP8X83LZrMjzJMjnrMu6eeKhN4zx Dr7CPSrvNHf+amHPAlv5gBZpMjczbnVaoODFvsj1mJRxEqW/sWIxtqZsA51bYtgF ceC5So4I/U/ZUAqmx26KBpNTSN0vUuOAqra6yD+15tHy24qMaqQSXY8fzRNboRV4 sRP0z92v9YlIfBlYU14etgWuK0W5RWbC+Cp+tpw8fdBetc591CIFIoB+Mv/SKzid TMSeaDCEBHdf0qoyVRk1QW8A5iuvWnh2KqkQU8u1/l0E0sw9Kb8GVFCilxBmtG8= =v1x/ -----END PGP SIGNATURE----- --=-0SZy4tGwEQjKTRv7VbEY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1376493464.1377.3.camel>